Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1608113

Re: [PATCH net] net: neigh: guard against NULL solicit() method

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH net] net: neigh: guard against NULL solicit() method
Date 2017-03-24 05:30 +0100
Message-ID <top1o-4qf-7@gated-at.bofh.it> (permalink)
References <todtg-4AG-19@gated-at.bofh.it> <toghs-6GO-15@gated-at.bofh.it> <togKu-6RO-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 23 Mar 2017 12:39:21 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> Dmitry posted a nice reproducer of a bug triggering in neigh_probe()
> when dereferencing a NULL neigh->ops->solicit method.
> 
> This can happen for arp_direct_ops/ndisc_direct_ops and similar,
> which can be used for NUD_NOARP neighbours (created when dev->header_ops
> is NULL). Admin can then force changing nud_state to some other state
> that would fire neigh timer.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>

Applied and queued up for -stable, thanks Eric.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

netlink: NULL timer crash Dmitry Vyukov <dvyukov@google.com> - 2017-03-23 14:00 +0100
  Re: netlink: NULL timer crash Eric Dumazet <edumazet@google.com> - 2017-03-23 16:00 +0100
    Re: netlink: NULL timer crash Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-23 17:10 +0100
      Re: netlink: NULL timer crash David Miller <davem@davemloft.net> - 2017-03-23 20:10 +0100
        [PATCH net] net: neigh: guard against NULL solicit() method Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-23 20:40 +0100
          Re: [PATCH net] net: neigh: guard against NULL solicit() method David Miller <davem@davemloft.net> - 2017-03-24 05:30 +0100
        Re: netlink: NULL timer crash Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-23 20:40 +0100

csiph-web