Re: netlink: NULL timer crash

From	Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: netlink: NULL timer crash
Date	2017-03-23 20:40 +0100
Message-ID	<togKv-6RO-51@gated-at.bofh.it> (permalink)
References	<toavo-2lS-23@gated-at.bofh.it> <tocnw-3Ak-27@gated-at.bofh.it> <todtg-4AG-19@gated-at.bofh.it> <toghs-6GO-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-03-23 at 12:00 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Thu, 23 Mar 2017 09:00:58 -0700
> 
> > On Thu, 2017-03-23 at 07:53 -0700, Eric Dumazet wrote:
> > 
> >> Nice !
> >> 
> >> Looks like neigh->ops->solicit is NULL
> > 
> > Apparently we allow admins to do really stupid things with neighbours
> > on tunnels.
> > 
> > Following patch should avoid the crash.
> > 
> > Anyone has better ideas ?
> 
> This is probably good enough for now, but you need to also handle
> dn_neigh_ops.
> 
> Another way to solve this is to add a NULL method check to the
> one spot where we invoke this method.  That clearly shows that
> the method is optional.

Yes, this would be a one liner. I will post this in a minute.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

netlink: NULL timer crash Dmitry Vyukov <dvyukov@google.com> - 2017-03-23 14:00 +0100
  Re: netlink: NULL timer crash Eric Dumazet <edumazet@google.com> - 2017-03-23 16:00 +0100
    Re: netlink: NULL timer crash Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-23 17:10 +0100
      Re: netlink: NULL timer crash David Miller <davem@davemloft.net> - 2017-03-23 20:10 +0100
        [PATCH net] net: neigh: guard against NULL solicit() method Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-23 20:40 +0100
          Re: [PATCH net] net: neigh: guard against NULL solicit() method David Miller <davem@davemloft.net> - 2017-03-24 05:30 +0100
        Re: netlink: NULL timer crash Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-23 20:40 +0100

csiph-web