Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1607439

Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

Show all headers | View raw

On Thu, Mar 23, 2017 at 12:22:30PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> info is being checked to see if it is a null pointer, however, vpgu is
> dereferencing info before this check, leading to a potential null
> pointer dereference.  If info is null, then the error message being
> printed by macro gvt_vgpu_err and this requires vpgu to exist. We can
> use a null vpgu as the macro has a sanity check to see if vpgu is null,
> so this is OK.

It is never NULL, it gets checked by its only caller.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer Colin King <colin.king@canonical.com> - 2017-03-23 13:30 +0100
  Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null  info pointer Chris Wilson <chris@chris-wilson.co.uk> - 2017-03-23 13:40 +0100
  Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null  info pointer Frans Klaver <fransklaver@gmail.com> - 2017-03-23 14:50 +0100
    Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null  info pointer Zhenyu Wang <zhenyuw@linux.intel.com> - 2017-03-24 04:50 +0100

csiph-web