Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1607433

[PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

info is being checked to see if it is a null pointer, however, vpgu is
dereferencing info before this check, leading to a potential null
pointer dereference.  If info is null, then the error message being
printed by macro gvt_vgpu_err and this requires vpgu to exist. We can
use a null vpgu as the macro has a sanity check to see if vpgu is null,
so this is OK.

Detected with CoverityScan, CID#1420672 ("Dereference nefore null check")

Fixes: 695fbc08d80f ("drm/i915/gvt: replace the gvt_err with gvt_vgpu_err")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/i915/gvt/kvmgt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
index 1ea3eb270de8..f8619a772c44 100644
--- a/drivers/gpu/drm/i915/gvt/kvmgt.c
+++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
@@ -1339,9 +1339,9 @@ static int kvmgt_guest_init(struct mdev_device *mdev)
 
 static bool kvmgt_guest_exit(struct kvmgt_guest_info *info)
 {
-	struct intel_vgpu *vgpu = info->vgpu;
-
 	if (!info) {
+		struct intel_vgpu *vgpu = NULL;
+
 		gvt_vgpu_err("kvmgt_guest_info invalid\n");
 		return false;
 	}
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null info pointer Colin King <colin.king@canonical.com> - 2017-03-23 13:30 +0100
  Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null  info pointer Chris Wilson <chris@chris-wilson.co.uk> - 2017-03-23 13:40 +0100
  Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null  info pointer Frans Klaver <fransklaver@gmail.com> - 2017-03-23 14:50 +0100
    Re: [PATCH] drm/i915/kvmgt: avoid dereferencing a potentially null  info pointer Zhenyu Wang <zhenyuw@linux.intel.com> - 2017-03-24 04:50 +0100

csiph-web