Re: [PATCH v3 1/2] module: verify address is read-only

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] module: verify address is read-only
Date	2017-03-25 03:00 +0100
Message-ID	<toJ9M-22w-5@gated-at.bofh.it> (permalink)
References	<to18J-49M-11@gated-at.bofh.it> <to18K-49M-21@gated-at.bofh.it> <toI42-1iY-3@gated-at.bofh.it> <toJ05-1WW-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Mar 24, 2017 at 6:41 PM, Eddie Kovsky <ewk@edkovsky.org> wrote:
> On 03/24/17, Jessica Yu wrote:
>> +++ Eddie Kovsky [22/03/17 20:55 -0600]:
>> > Implement a mechanism to check if a module's address is in
>> > the rodata or ro_after_init sections. It mimics the exsiting functions
>> > that test if an address is inside a module's text section.
>> >
>> > Functions that take a module as an argument will be able to
>>
>> > verify that the module is in a read-only section.
>>
>> s/module/module address/?
>>
> Yes, that is more accurate.
>
>> Also, there is some useful information in your cover letter on the
>> context and motivation for adding to the api, it would be good to
>> reproduce that info here so that we can have it officially in the
>> changelog. (sentences "This implements a suggestion made by Kees..."
>> and "The idea is to prevent structures..." would be nice to copy here)
>>
> Okay, that's easy to add.
>
> Kees, would you like me to add your Suggested-by as well?

Sure! I'm find either way. :)

-Kees

-- 
Kees Cook
Pixel Security

Thread

[PATCH v3 0/2] provide check for ro_after_init memory sections Eddie Kovsky <ewk@edkovsky.org> - 2017-03-23 04:00 +0100
  [PATCH v3 1/2] module: verify address is read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-03-23 04:00 +0100
    Re: [PATCH v3 1/2] module: verify address is read-only Kees Cook <keescook@chromium.org> - 2017-03-23 22:20 +0100
      Re: [PATCH v3 1/2] module: verify address is read-only Jessica Yu <jeyu@redhat.com> - 2017-03-25 01:50 +0100
        Re: [PATCH v3 1/2] module: verify address is read-only Kees Cook <keescook@chromium.org> - 2017-03-25 03:00 +0100
    Re: [PATCH v3 1/2] module: verify address is read-only Jessica Yu <jeyu@redhat.com> - 2017-03-25 01:50 +0100
      Re: [PATCH v3 1/2] module: verify address is read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-03-25 02:50 +0100
        Re: [PATCH v3 1/2] module: verify address is read-only Kees Cook <keescook@chromium.org> - 2017-03-25 03:00 +0100
  [PATCH v3 2/2] extable: verify address is read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-03-23 04:00 +0100
    Re: [PATCH v3 2/2] extable: verify address is read-only Kees Cook <keescook@chromium.org> - 2017-03-23 22:20 +0100

csiph-web