Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1609060

Re: [PATCH v3 1/2] module: verify address is read-only

Show all headers | View raw

On Fri, Mar 24, 2017 at 5:42 PM, Jessica Yu <jeyu@redhat.com> wrote:
> +++ Kees Cook [23/03/17 14:13 -0700]:
>>
>> On Wed, Mar 22, 2017 at 7:55 PM, Eddie Kovsky <ewk@edkovsky.org> wrote:
>>>
>>> Implement a mechanism to check if a module's address is in
>>> the rodata or ro_after_init sections. It mimics the exsiting functions
>>> that test if an address is inside a module's text section.
>>>
>>> Functions that take a module as an argument will be able to
>>> verify that the module is in a read-only section.
>>>
>>> Signed-off-by: Eddie Kovsky <ewk@edkovsky.org>
>>
>>
>> Awesome! I'll be glad to have these.
>>
>> Reviewed-by: Kees Cook <keescook@chromium.org>
>>
>> Jessica, if this looks good to you, should this go via modules or via
>> my tree? If mine, can I have your Ack?
>
>
> Sure, would be happy to let you take this patch through your tree. I
> only had a few minor comments left, so I think just one more small
> respin and it'll be good to go.

Awesome, I'll wait for v4 and your Ack and put it through the kspp tree. :)

Thanks for the review!

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/2] provide check for ro_after_init memory sections Eddie Kovsky <ewk@edkovsky.org> - 2017-03-23 04:00 +0100
  [PATCH v3 1/2] module: verify address is read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-03-23 04:00 +0100
    Re: [PATCH v3 1/2] module: verify address is read-only Kees Cook <keescook@chromium.org> - 2017-03-23 22:20 +0100
      Re: [PATCH v3 1/2] module: verify address is read-only Jessica Yu <jeyu@redhat.com> - 2017-03-25 01:50 +0100
        Re: [PATCH v3 1/2] module: verify address is read-only Kees Cook <keescook@chromium.org> - 2017-03-25 03:00 +0100
    Re: [PATCH v3 1/2] module: verify address is read-only Jessica Yu <jeyu@redhat.com> - 2017-03-25 01:50 +0100
      Re: [PATCH v3 1/2] module: verify address is read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-03-25 02:50 +0100
        Re: [PATCH v3 1/2] module: verify address is read-only Kees Cook <keescook@chromium.org> - 2017-03-25 03:00 +0100
  [PATCH v3 2/2] extable: verify address is read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-03-23 04:00 +0100
    Re: [PATCH v3 2/2] extable: verify address is read-only Kees Cook <keescook@chromium.org> - 2017-03-23 22:20 +0100

csiph-web