Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq()

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq()
Date	Thu, 23 Mar 2017 10:30:02 +0100
Message-ID	<to7ea-eW-17@gated-at.bofh.it> (permalink)
References	<to0w1-3Qh-11@gated-at.bofh.it> <to0w1-3Qh-15@gated-at.bofh.it>
X-Original-To	peterz@infradead.org, mingo@kernel.org
X-Original-Senderip	156.147.1.125
X-Original-Mailfrom	byungchul.park@lge.com
X-Original-Senderip	10.177.222.33
X-Original-Mailfrom	byungchul.park@lge.com
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	58
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, juri.lelli@gmail.com, rostedt@goodmis.org, kernel-team@lge.com, srostedt@redhat.com, ghaskins@novell.com
X-Original-Date	Thu, 23 Mar 2017 18:21:23 +0900
X-Original-Message-ID	<20170323092123.GP11100@X58A-UD3R>
X-Original-References	<1490235169-370-1-git-send-email-byungchul.park@lge.com> <1490235169-370-3-git-send-email-byungchul.park@lge.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1607292

Show key headers only | View raw

On Thu, Mar 23, 2017 at 11:12:49AM +0900, Byungchul Park wrote:
> It would be better to avoid pushing tasks to other cpu within
> a SD_PREFER_SIBLING domain, instead, get more chances to check other
> siblings.

+cc ghaskins@novell.com
+cc srostedt@redhat.com

> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
>  kernel/sched/rt.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 979b734..6332b2ad 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1624,6 +1624,7 @@ static int find_lowest_rq(struct task_struct *task)
>  	struct cpumask *lowest_mask = this_cpu_cpumask_var_ptr(local_cpu_mask);
>  	int this_cpu = smp_processor_id();
>  	int cpu      = task_cpu(task);
> +	int fallback_cpu = -1;
>  
>  	/* Make sure the mask is initialized first */
>  	if (unlikely(!lowest_mask))
> @@ -1671,6 +1672,15 @@ static int find_lowest_rq(struct task_struct *task)
>  			best_cpu = cpumask_first_and(lowest_mask,
>  						     sched_domain_span(sd));
>  			if (best_cpu < nr_cpu_ids) {
> +				/*
> +				 * If current domain is SD_PREFER_SIBLING
> +				 * flaged, we have to get more chances to
> +				 * check other siblings.
> +				 */
> +				if (sd->flags & SD_PREFER_SIBLING) {
> +					fallback_cpu = best_cpu;
> +					continue;
> +				}
>  				rcu_read_unlock();
>  				return best_cpu;
>  			}
> @@ -1679,6 +1689,13 @@ static int find_lowest_rq(struct task_struct *task)
>  	rcu_read_unlock();
>  
>  	/*
> +	 * If fallback_cpu is valid, all our quesses failed *except* for
> +	 * SD_PREFER_SIBLING domain. Now, we can return the fallback cpu.
> +	 */
> +	if (fallback_cpu != -1)
> +		return fallback_cpu;
> +
> +	/*
>  	 * And finally, if there were no matches within the domains
>  	 * just give the caller *something* to work with from the compatible
>  	 * locations.
> -- 
> 1.9.1

Thread

[PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq() Byungchul Park <byungchul.park@lge.com> - 2017-03-23 03:20 +0100
  Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Byungchul Park <byungchul.park@lge.com> - 2017-03-23 10:30 +0100
    Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Steven Rostedt <rostedt@goodmis.org> - 2017-03-23 15:00 +0100
  Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Peter Zijlstra <peterz@infradead.org> - 2017-03-23 10:50 +0100
    Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Byungchul Park <byungchul.park@lge.com> - 2017-03-23 11:40 +0100
      Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Steven Rostedt <rostedt@goodmis.org> - 2017-03-23 15:10 +0100
        Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Byungchul Park <byungchul.park@lge.com> - 2017-03-23 23:50 +0100

csiph-web