Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq()

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq()
Date	2017-03-23 15:10 +0100
Message-ID	<tobB8-3e8-13@gated-at.bofh.it> (permalink)
References	<to0w1-3Qh-11@gated-at.bofh.it> <to0w1-3Qh-15@gated-at.bofh.it> <to7xw-mT-13@gated-at.bofh.it> <to8jU-XG-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 23 Mar 2017 19:36:51 +0900
Byungchul Park <byungchul.park@lge.com> wrote:

> On Thu, Mar 23, 2017 at 10:44:45AM +0100, Peter Zijlstra wrote:
> > On Thu, Mar 23, 2017 at 11:12:49AM +0900, Byungchul Park wrote:  
> > > It would be better to avoid pushing tasks to other cpu within
> > > a SD_PREFER_SIBLING domain, instead, get more chances to check
> > > other siblings.  
> > 
> > Did you forget to post the rt equivalent to patch 1?  
> 
> No. Fortunately, rt currently works as patch 1 does.

I'm thinking that the rt and deadline search for lowest rq functions
should be merged as one.

What they are doing is looking for the rq with the lowest priority.
deadline currently doesn't care if it picks an rq with an rt task
running on it, even when there's an rq with no rt tasks that the dl task
can migrate to. The same goes with rt. It could place an RT task on an
rq running a deadline task without knowing the rt task wont be able to
run on that cpu immediately.

-- Steve

Thread

[PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq() Byungchul Park <byungchul.park@lge.com> - 2017-03-23 03:20 +0100
  Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Byungchul Park <byungchul.park@lge.com> - 2017-03-23 10:30 +0100
    Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Steven Rostedt <rostedt@goodmis.org> - 2017-03-23 15:00 +0100
  Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Peter Zijlstra <peterz@infradead.org> - 2017-03-23 10:50 +0100
    Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Byungchul Park <byungchul.park@lge.com> - 2017-03-23 11:40 +0100
      Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Steven Rostedt <rostedt@goodmis.org> - 2017-03-23 15:10 +0100
        Re: [PATCH v3 3/3] sched/rt: Add support for SD_PREFER_SIBLING on  find_lowest_rq() Byungchul Park <byungchul.park@lge.com> - 2017-03-23 23:50 +0100

csiph-web