Re: [RFC][PATCH 2/4] printk: offload printing from wake_up_klogd_work_func()

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 2/4] printk: offload printing from wake_up_klogd_work_func()
Date	2017-03-23 10:10 +0100
Message-ID	<to6UO-89-5@gated-at.bofh.it> (permalink)
References	<ti0fn-8f0-15@gated-at.bofh.it> <ti0p3-8iJ-1@gated-at.bofh.it> <tlZb4-6ms-19@gated-at.bofh.it> <tmjjs-4mz-7@gated-at.bofh.it> <tn8lX-7kZ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (03/20/17 17:09), Petr Mladek wrote:
[..]
> 
> BTW: wake_up_klogd_work does not need to be per-CPU as well.
> irq_work infrastructure heavily uses per-CPU variables.
> But a global struct irq_work is safe, see irq_work_claim().

so I have a patch that turns wake_up_klogd_work into a global variable,
out of curiosity, but I'm not entire sure about it. the sort of a problem
is that queued irq_works still go into a per-CPU run_lists.  per-CPU
wake_up_klogd_work permits us to queue irq work on several CPUs so we
might have better chances to execute wake_up_klogd_work_func(), while
global wake_up_klogd_work will be only in one run_list. this can defer
wake_up_klogd_work processing until that particular single CPU handles
its interrupt and calls irq_work_run_list(). what do you think?

	-ss

Thread

Re: [RFC][PATCH 2/4] printk: offload printing from  wake_up_klogd_work_func() Petr Mladek <pmladek@suse.com> - 2017-03-17 13:30 +0100
  Re: [RFC][PATCH 2/4] printk: offload printing from  wake_up_klogd_work_func() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-18 11:00 +0100
    Re: [RFC][PATCH 2/4] printk: offload printing from  wake_up_klogd_work_func() Petr Mladek <pmladek@suse.com> - 2017-03-20 17:30 +0100
      Re: [RFC][PATCH 2/4] printk: offload printing from  wake_up_klogd_work_func() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-21 05:10 +0100
      Re: [RFC][PATCH 2/4] printk: offload printing from  wake_up_klogd_work_func() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-23 10:10 +0100
        Re: [RFC][PATCH 2/4] printk: offload printing from  wake_up_klogd_work_func() Petr Mladek <pmladek@suse.com> - 2017-03-23 13:20 +0100

csiph-web