Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1607271

Re: [PATCH v2 1/4] pinctrl: rockchip: remove unnecessary locking

Show all headers | View raw

On Wed, Mar 15, 2017 at 6:46 PM, John Keeping <john@metanate.com> wrote:

> regmap_update_bits does its own locking and everything else accessed
> here is a local variable so there is no need to lock around it.
>
> Signed-off-by: John Keeping <john@metanate.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
> ---
> v2:
> - Also remove locking in rockchip_set_schmitt()

This does not apply on my "devel" branch in the pinctrl tree.

Please rebase on that and resend.

Since I have no patches for rockchip so far I suspect this
is not even based on v4.11-rc1 so pls forward-port.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] pinctrl: rockchip: PREEMPT_RT_FULL fixes John Keeping <john@metanate.com> - 2017-03-15 19:10 +0100
  [PATCH v2 4/4] pinctrl: rockchip: avoid hardirq-unsafe functions in irq_chip John Keeping <john@metanate.com> - 2017-03-15 19:20 +0100
  [PATCH v2 1/4] pinctrl: rockchip: remove unnecessary locking John Keeping <john@metanate.com> - 2017-03-15 19:20 +0100
    [PATCH v2.1 1/4] pinctrl: rockchip: remove unnecessary locking John Keeping <john@metanate.com> - 2017-03-15 20:00 +0100
    Re: [PATCH v2 1/4] pinctrl: rockchip: remove unnecessary locking Linus Walleij <linus.walleij@linaro.org> - 2017-03-23 10:10 +0100
  [PATCH v2 2/4] pinctrl: rockchip: convert to raw spinlock John Keeping <john@metanate.com> - 2017-03-15 19:20 +0100
  [PATCH v2 3/4] pinctrl: rockchip: split out verification of mux settings John Keeping <john@metanate.com> - 2017-03-15 19:20 +0100

csiph-web