Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1607218

Re: [PATCHv2 09/11] Bluetooth: add nokia driver

Show all headers | View raw

Hello Sebastian,

Le 21/03/2017 à 23:32, Sebastian Reichel a écrit :
> This adds a driver for the Nokia H4+ protocol, which is used
> at least on the Nokia N9, N900 & N950.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> Changes since PATCHv1:
>   * replace __u8 and uint8_t with u8
>   * replace __u16 and uint16_t with u16
>   * drop BT_BAUDRATE_DIVIDER and use btdev->sysclk_speed * 10 instead
>   * fix wording of a sentence
>   * fix error path of negotation & alive package receive functions
>   * replaced nokia_wait_for_cts with newly introduced serdev function
>   * use "nokia,h4p-bluetooth" as compatible string
> ---
>   drivers/bluetooth/Kconfig     |  12 +
>   drivers/bluetooth/Makefile    |   2 +
>   drivers/bluetooth/hci_nokia.c | 819 ++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 833 insertions(+)
>   create mode 100644 drivers/bluetooth/hci_nokia.c
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index c2c14a12713b..2e3e4d3547ad 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -86,6 +86,18 @@ config BT_HCIUART_H4
>   
>   	  Say Y here to compile support for HCI UART (H4) protocol.
>   
> +config BT_HCIUART_NOKIA
> +	tristate "UART Nokia H4+ protocol support"
> +	depends on BT_HCIUART
> +	depends on SERIAL_DEV_BUS
> +	depends on PM
> +	help
> +	  Nokia H4+ is serial protocol for communication between Bluetooth
> +	  device and host. This protocol is required for Bluetooth devices
> +	  with UART interface in Nokia devices.
> +
> +	  Say Y here to compile support for Nokia's H4+ protocol.
> +
>   config BT_HCIUART_BCSP
>   	bool "BCSP protocol support"
>   	depends on BT_HCIUART
> diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile
> index fd571689eed6..a7f237320f4b 100644
> --- a/drivers/bluetooth/Makefile
> +++ b/drivers/bluetooth/Makefile
> @@ -25,6 +25,8 @@ obj-$(CONFIG_BT_BCM)		+= btbcm.o
>   obj-$(CONFIG_BT_RTL)		+= btrtl.o
>   obj-$(CONFIG_BT_QCA)		+= btqca.o
>   
> +obj-$(CONFIG_BT_HCIUART_NOKIA)	+= hci_nokia.o
> +
>   btmrvl-y			:= btmrvl_main.o
>   btmrvl-$(CONFIG_DEBUG_FS)	+= btmrvl_debugfs.o

This does not build as module with following error:
ERROR: "hci_uart_tx_wakeup" [drivers/bluetooth/hci_nokia.ko] undefined!
ERROR: "hci_uart_register_device" [drivers/bluetooth/hci_nokia.ko] 
undefined!

Should not hci_nokia be part of the hci_uart module?

Regards,

Fred

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv2 00/11] Nokia H4+ support Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
  [PATCHv2 09/11] Bluetooth: add nokia driver Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 09/11] Bluetooth: add nokia driver Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:30 +0100
      Re: [PATCHv2 09/11] Bluetooth: add nokia driver Sebastian Reichel <sre@kernel.org> - 2017-03-22 23:50 +0100
    Re: [PATCHv2 09/11] Bluetooth: add nokia driver Frédéric Danis <frederic.danis.oss@gmail.com> - 2017-03-23 09:00 +0100
      Re: [PATCHv2 09/11] Bluetooth: add nokia driver Sebastian Reichel <sre@kernel.org> - 2017-03-23 10:10 +0100
  [PATCHv2 07/11] serdev: add helpers for cts and rts handling Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 07/11] serdev: add helpers for cts and rts handling Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:10 +0100
  [PATCHv2 06/11] serdev: implement get/set tiocm Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    [PATCHv2.1] serdev: implement get/set tiocm Sebastian Reichel <sre@kernel.org> - 2017-03-22 02:10 +0100
      Re: [PATCHv2.1] serdev: implement get/set tiocm Pavel Machek <pavel@ucw.cz> - 2017-03-22 10:50 +0100
      Re: [PATCHv2.1] serdev: implement get/set tiocm Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:20 +0100
  [PATCHv2 03/11] Bluetooth: hci_serdev: do not open device in hci open Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
  [PATCHv2 08/11] dt-bindings: net: bluetooth: Add nokia-bluetooth Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 08/11] dt-bindings: net: bluetooth: Add nokia-bluetooth Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:10 +0100
  [PATCHv2 01/11] Bluetooth: hci_uart: add support for word alignment Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
  [PATCHv2 05/11] serdev: add serdev_device_wait_until_sent Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 05/11] serdev: add serdev_device_wait_until_sent Pavel Machek <pavel@ucw.cz> - 2017-03-22 10:50 +0100
  [PATCHv2 10/11] ARM: dts: N900: Add bluetooth Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 10/11] ARM: dts: N900: Add bluetooth Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:10 +0100
      Re: [PATCHv2 10/11] ARM: dts: N900: Add bluetooth Tony Lindgren <tony@atomide.com> - 2017-03-23 01:00 +0100
  [PATCHv2 11/11] ARM: dts: N9/N950: add bluetooth Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 11/11] ARM: dts: N9/N950: add bluetooth Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:10 +0100

csiph-web