Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1606316

Re: [PATCHv2 05/11] serdev: add serdev_device_wait_until_sent

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi!

> @@ -47,10 +48,13 @@ static void ttyport_write_wakeup(struct tty_port *port)
>  	struct serport *serport = serdev_controller_get_drvdata(ctrl);
>  
>  	if (!test_and_clear_bit(TTY_DO_WRITE_WAKEUP, &port->tty->flags))
> -		return;
> +		goto out;
>  
>  	if (test_bit(SERPORT_ACTIVE, &serport->flags))
>  		serdev_controller_write_wakeup(ctrl);
> +
> +out:

I'd do "if (test_and_clear_bit() && test_bit()) serdev_()"
here. Otherwise it looks fine.

Acked-by: Pavel Machek <pavel@ucw.cz>

									Pavel
									
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHv2 00/11] Nokia H4+ support Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
  [PATCHv2 09/11] Bluetooth: add nokia driver Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 09/11] Bluetooth: add nokia driver Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:30 +0100
      Re: [PATCHv2 09/11] Bluetooth: add nokia driver Sebastian Reichel <sre@kernel.org> - 2017-03-22 23:50 +0100
    Re: [PATCHv2 09/11] Bluetooth: add nokia driver Frédéric Danis <frederic.danis.oss@gmail.com> - 2017-03-23 09:00 +0100
      Re: [PATCHv2 09/11] Bluetooth: add nokia driver Sebastian Reichel <sre@kernel.org> - 2017-03-23 10:10 +0100
  [PATCHv2 07/11] serdev: add helpers for cts and rts handling Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 07/11] serdev: add helpers for cts and rts handling Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:10 +0100
  [PATCHv2 06/11] serdev: implement get/set tiocm Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    [PATCHv2.1] serdev: implement get/set tiocm Sebastian Reichel <sre@kernel.org> - 2017-03-22 02:10 +0100
      Re: [PATCHv2.1] serdev: implement get/set tiocm Pavel Machek <pavel@ucw.cz> - 2017-03-22 10:50 +0100
      Re: [PATCHv2.1] serdev: implement get/set tiocm Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:20 +0100
  [PATCHv2 03/11] Bluetooth: hci_serdev: do not open device in hci open Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
  [PATCHv2 08/11] dt-bindings: net: bluetooth: Add nokia-bluetooth Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 08/11] dt-bindings: net: bluetooth: Add nokia-bluetooth Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:10 +0100
  [PATCHv2 01/11] Bluetooth: hci_uart: add support for word alignment Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
  [PATCHv2 05/11] serdev: add serdev_device_wait_until_sent Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 05/11] serdev: add serdev_device_wait_until_sent Pavel Machek <pavel@ucw.cz> - 2017-03-22 10:50 +0100
  [PATCHv2 10/11] ARM: dts: N900: Add bluetooth Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 10/11] ARM: dts: N900: Add bluetooth Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:10 +0100
      Re: [PATCHv2 10/11] ARM: dts: N900: Add bluetooth Tony Lindgren <tony@atomide.com> - 2017-03-23 01:00 +0100
  [PATCHv2 11/11] ARM: dts: N9/N950: add bluetooth Sebastian Reichel <sre@kernel.org> - 2017-03-21 23:40 +0100
    Re: [PATCHv2 11/11] ARM: dts: N9/N950: add bluetooth Rob Herring <robh+dt@kernel.org> - 2017-03-22 22:10 +0100

csiph-web