Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1605332

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

Show all headers | View raw

Hi,

I think it again.
The "cht_wcove_pwrsrc' is ok, if the register use the 'pwrsrc' word
and using the 'wcove' instead of 'wc'. It is not big matter.

I agree to use the 'cht_wcove_pwrsrc'.

Best Regards,
Chanwoo Choi


On 2017년 03월 21일 14:21, Chanwoo Choi wrote:
> On 2017년 03월 21일 12:54, Chanwoo Choi wrote:
>> On 2017년 03월 20일 22:00, Andy Shevchenko wrote:
>>> On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote:
>>>> On 2017년 03월 17일 18:55, Hans de Goede wrote:
>>>
>>>>> +static const struct platform_device_id cht_wc_extcon_table[] = {
>>>>> +	{ .name = "cht_wcove_pwrsrc" },
>>>>
>>>> You use the 'cht_wc' word instead of 'cht_wcove_pwrsrc'.
>>>> So, To maintain the consistency, you better to use the 'cht-wc' as the
>>>> name.
>>>> - I prefer to use '-' instead of '_' in the name.
>>>> 	.name ="cht-wc"
>>>
>>> I would keep as Hans did for the sake of consistency among all Whiskey
>>> Cove device drivers (and predecessors like Crystal Cove).
>>
>> The 'wcove' short word is not used in this patch.
>> If the author want to use the 'wcove', I recommend that
>> you should use the 'wcove' instead of 'wc' in this patch.
>>
>> And, I think that  'pwrsrc' is not ambiguous.
> 
> I'm sorry. I used the wrong word. I mean that 'pwrsrc' is not correct.
> 
>> Hans might use the 'pwrsrc' as the 'Power Source'.
>> But, this driver is not power source. Instead,
>> this driver supports the detection of external connector.
>>
>> I think 'power source' means the power supply instead of detector.
>>
>>>
>>> I understand your point from extcon subsystem view, but PMICs like
>>> Whiskey Cove are multi-functional devices, and thus naming across them
>>> (same prefix in use to be precise) is better idea.
>>>
>>>>
>>>>> +	{},
>>>>> +};
>>>>> +MODULE_DEVICE_TABLE(platform, cht_wc_extcon_table);
>>>
>>
>>
> 
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver Hans de Goede <hdegoede@redhat.com> - 2017-03-17 11:00 +0100
  Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey  Cove PMIC extcon driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-17 18:20 +0100
    Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Hans de Goede <hdegoede@redhat.com> - 2017-03-20 19:10 +0100
  Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-20 02:50 +0100
    Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey  Cove PMIC extcon driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-20 14:10 +0100
      Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-21 05:00 +0100
        Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-21 06:30 +0100
          Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-21 07:30 +0100
    Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Hans de Goede <hdegoede@redhat.com> - 2017-03-20 21:00 +0100
      Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-21 06:20 +0100
        Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Hans de Goede <hdegoede@redhat.com> - 2017-03-23 16:30 +0100

csiph-web