Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604535

Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver

From Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver
Date 2017-03-20 14:10 +0100
Message-ID <tn5eq-5aQ-23@gated-at.bofh.it> (permalink)
References <tlWPT-4pa-5@gated-at.bofh.it> <tmUCm-5RZ-13@gated-at.bofh.it> <tlWPT-4pa-3@gated-at.bofh.it> <tmUCl-5RZ-11@gated-at.bofh.it>
Organization Intel Finland Oy

Show all headers | View raw

On Mon, 2017-03-20 at 10:33 +0900, Chanwoo Choi wrote:
> On 2017년 03월 17일 18:55, Hans de Goede wrote:

> > +static const struct platform_device_id cht_wc_extcon_table[] = {
> > +	{ .name = "cht_wcove_pwrsrc" },
> 
> You use the 'cht_wc' word instead of 'cht_wcove_pwrsrc'.
> So, To maintain the consistency, you better to use the 'cht-wc' as the
> name.
> - I prefer to use '-' instead of '_' in the name.
> 	.name ="cht-wc"

I would keep as Hans did for the sake of consistency among all Whiskey
Cove device drivers (and predecessors like Crystal Cove).

I understand your point from extcon subsystem view, but PMICs like
Whiskey Cove are multi-functional devices, and thus naming across them
(same prefix in use to be precise) is better idea.

> 
> > +	{},
> > +};
> > +MODULE_DEVICE_TABLE(platform, cht_wc_extcon_table);

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove PMIC extcon driver Hans de Goede <hdegoede@redhat.com> - 2017-03-17 11:00 +0100
  Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey  Cove PMIC extcon driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-17 18:20 +0100
    Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Hans de Goede <hdegoede@redhat.com> - 2017-03-20 19:10 +0100
  Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-20 02:50 +0100
    Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey  Cove PMIC extcon driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-03-20 14:10 +0100
      Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-21 05:00 +0100
        Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-21 06:30 +0100
          Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-21 07:30 +0100
    Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Hans de Goede <hdegoede@redhat.com> - 2017-03-20 21:00 +0100
      Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-21 06:20 +0100
        Re: [PATCH 03/15] extcon: cht-wc: Add Intel Cherry Trail Whiskey Cove  PMIC extcon driver Hans de Goede <hdegoede@redhat.com> - 2017-03-23 16:30 +0100

csiph-web