Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1604975
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling |
| Date | 2017-03-20 19:20 +0100 |
| Message-ID | <tna4s-52-93@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <tn2gA-2R9-55@gated-at.bofh.it> <tn2qd-3a9-7@gated-at.bofh.it> <tn2JB-3lh-29@gated-at.bofh.it> <tn3cC-3xv-7@gated-at.bofh.it> <tn3mj-3Qx-45@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 20 March 2017 at 12:00, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote:
>> On 20.03.2017 11:27, Philipp Zabel wrote:
> [...]
>> > diff --git a/include/linux/reset.h b/include/linux/reset.h
>> > index 86b4ed75359e8..c905ff1c21ec6 100644
>> > --- a/include/linux/reset.h
>> > +++ b/include/linux/reset.h
>> > @@ -74,14 +74,14 @@ static inline struct reset_control *__of_reset_control_get(
>> > const char *id, int index, bool shared,
>> > bool optional)
>> > {
>> > - return ERR_PTR(-ENOTSUPP);
>> > + return optional ? NULL : ERR_PTR(-ENOTSUPP);
>> > }
>> >
>> > static inline struct reset_control *__devm_reset_control_get(
>> > struct device *dev, const char *id,
>> > int index, bool shared, bool optional)
>> > {
>> > - return ERR_PTR(-ENOTSUPP);
>> > + return optional ? NULL : ERR_PTR(-ENOTSUPP);
>> > }
>> >
>> > #endif /* CONFIG_RESET_CONTROLLER */
>> > ---------->8----------
>>
>> In dw_mmc.c file there are also unconditional calls to
>> reset_control_assert, with disabled RESET_CONTROLLER it will cause
>> unexpected WARNs.
>> Anyway if you change reset API as above I think you should remove all
>> warns from reset stubs, because NULL reset is valid, but these warns are
>> there for reason - contradiction.
>
> You are right, I have to let go of those, too.
Until fixed, I have dropped the three changes from my next branch
related to this. Please re-post when fixed.
Kind regards
Uffe
>
> regards
> Philipp
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Philipp Zabel <p.zabel@pengutronix.de> - 2017-03-15 12:40 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-16 15:50 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Andrzej Hajda <a.hajda@samsung.com> - 2017-03-20 10:30 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Philipp Zabel <p.zabel@pengutronix.de> - 2017-03-20 11:00 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Andrzej Hajda <a.hajda@samsung.com> - 2017-03-20 11:10 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Philipp Zabel <p.zabel@pengutronix.de> - 2017-03-20 11:30 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Andrzej Hajda <a.hajda@samsung.com> - 2017-03-20 12:00 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Philipp Zabel <p.zabel@pengutronix.de> - 2017-03-20 12:10 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-20 19:10 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-20 19:20 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Jaehoon Chung <jh80.chung@samsung.com> - 2017-03-21 13:20 +0100
csiph-web