Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1604270
| From | Andrzej Hajda <a.hajda@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling |
| Date | 2017-03-20 10:30 +0100 |
| Message-ID | <tn1Nv-2FR-3@gated-at.bofh.it> (permalink) |
| References | <tlfrA-6ZQ-11@gated-at.bofh.it> <tn1Nv-2FR-5@gated-at.bofh.it> <tlfrA-6ZQ-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Philipp,
Todays next branch does not work with exynos5433-tm2 board.
I guess this patch causes regression. On MMC without reset controller I
get errors:
[ 4.938222] dwmmc_exynos 15540000.mshc: platform data not available
[ 4.943268] dwmmc_exynos: probe of 15540000.mshc failed with error -22
[ 4.950184] dwmmc_exynos 15560000.mshc: platform data not available
[ 4.955962] dwmmc_exynos: probe of 15560000.mshc failed with error -22
Commenting out reset controller get and error checks 'fixes' the issue.
On 15.03.2017 12:31, Philipp Zabel wrote:
> As of commit bb475230b8e5 ("reset: make optional functions really
> optional"), the reset framework API calls use NULL pointers to describe
> optional, non-present reset controls.
>
> This allows to return errors from devm_reset_control_get_optional and to
> call reset_control_(de)assert unconditionally.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/mmc/host/dw_mmc.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a9ac0b4573131..3d62b0a1f81cb 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2968,10 +2968,8 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>
> /* find reset controller when exist */
> pdata->rstc = devm_reset_control_get_optional(dev, "reset");
> - if (IS_ERR(pdata->rstc)) {
> - if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
> - return ERR_PTR(-EPROBE_DEFER);
> - }
> + if (IS_ERR(pdata->rstc))
> + return ERR_CAST(pdata->rstc);
With three lines above commented out it works.
Regards
Andrzej
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Philipp Zabel <p.zabel@pengutronix.de> - 2017-03-15 12:40 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-16 15:50 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Andrzej Hajda <a.hajda@samsung.com> - 2017-03-20 10:30 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Philipp Zabel <p.zabel@pengutronix.de> - 2017-03-20 11:00 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Andrzej Hajda <a.hajda@samsung.com> - 2017-03-20 11:10 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Philipp Zabel <p.zabel@pengutronix.de> - 2017-03-20 11:30 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Andrzej Hajda <a.hajda@samsung.com> - 2017-03-20 12:00 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Philipp Zabel <p.zabel@pengutronix.de> - 2017-03-20 12:10 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-20 19:10 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Ulf Hansson <ulf.hansson@linaro.org> - 2017-03-20 19:20 +0100
Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling Jaehoon Chung <jh80.chung@samsung.com> - 2017-03-21 13:20 +0100
csiph-web