Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1606696

Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc

Show all headers | View raw

Hi Jacopo,

On Wed, Mar 22, 2017 at 4:36 PM, jacopo <jacopo@jmondi.org> wrote:
> On Wed, Mar 22, 2017 at 02:20:08PM +0100, Geert Uytterhoeven wrote:
>> On Wed, Mar 22, 2017 at 11:33 AM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>> > On Mon, Mar 20, 2017 at 5:14 PM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
>> >> Add device tree bindings documentation for Renesas RZ/A1 gpio and pin
>> >> --- /dev/null
>> >> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza1-pinctrl.txt
>>
>> ulating the pin index from its position
>> >> +      (port where it sits on and pin offset), and alternate function
>> >> +      configuration options are provided in pin controller header file at:
>> >
>> > the pin ... file
>> >
>> >> +      include/dt-bindings/pinctrl/r7s72100-pinctrl.h
>> >
>> > Hence I'd include that file in this patch, as it's part of the bindings.
>>
>> Ah, that would create a hard dependency between the DTS files and the
>> DT bindings, which typically go in through different trees.
>> As the driver replicates the definitions from the header, the include file
>> can go in with the DTS updates.
>>
>
> Sorry, got confused by multiple reviews here..
> Are you suggesting to squash [03/07] in [04/07] here?

No, I suggested to squash [03/07] into [02/07].

But upon second thought, that's not such a good idea, as it creates an
additional dependency.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/7] Renesas RZ/A1 pin and gpio controller Jacopo Mondi <jacopo+renesas@jmondi.org> - 2017-03-20 17:30 +0100
  [PATCH v2 6/7] arm: dts: genmai: Add RIIC2 pin group Jacopo Mondi <jacopo+renesas@jmondi.org> - 2017-03-20 17:30 +0100
    Re: [PATCH v2 6/7] arm: dts: genmai: Add RIIC2 pin group Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-22 14:20 +0100
  [PATCH v2 7/7] arm: dts: genmai: Add user led device nodes Jacopo Mondi <jacopo+renesas@jmondi.org> - 2017-03-20 17:30 +0100
    Re: [PATCH v2 7/7] arm: dts: genmai: Add user led device nodes Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-22 14:30 +0100
  [PATCH v2 1/7] pinctrl: Renesas RZ/A1 pin and gpio controller Jacopo Mondi <jacopo+renesas@jmondi.org> - 2017-03-20 17:50 +0100
    Re: [PATCH v2 1/7] pinctrl: Renesas RZ/A1 pin and gpio controller Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-22 11:30 +0100
      Re: [PATCH v2 1/7] pinctrl: Renesas RZ/A1 pin and gpio controller jacopo <jacopo@jmondi.org> - 2017-03-23 15:30 +0100
  [PATCH v2 4/7] arm: dts: r7s72100: Add pin controller node Jacopo Mondi <jacopo+renesas@jmondi.org> - 2017-03-20 17:50 +0100
    Re: [PATCH v2 4/7] arm: dts: r7s72100: Add pin controller node Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-22 14:20 +0100
      Re: [PATCH v2 4/7] arm: dts: r7s72100: Add pin controller node jacopo <jacopo@jmondi.org> - 2017-03-23 17:20 +0100
  [PATCH v2 3/7] arm: dts: dt-bindings: Add Renesas RZ pinctrl header Jacopo Mondi <jacopo+renesas@jmondi.org> - 2017-03-20 18:00 +0100
    Re: [PATCH v2 3/7] arm: dts: dt-bindings: Add Renesas RZ pinctrl header Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-22 11:40 +0100
  [PATCH v2 5/7] arm: dts: genmai: Add SCIF2 pin group Jacopo Mondi <jacopo+renesas@jmondi.org> - 2017-03-20 18:00 +0100
    Re: [PATCH v2 5/7] arm: dts: genmai: Add SCIF2 pin group Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-22 14:20 +0100
  [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Jacopo Mondi <jacopo+renesas@jmondi.org> - 2017-03-20 18:30 +0100
    Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-22 11:40 +0100
      Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-22 14:30 +0100
        Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc jacopo <jacopo@jmondi.org> - 2017-03-22 16:40 +0100
          Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc Geert Uytterhoeven <geert@linux-m68k.org> - 2017-03-22 17:00 +0100
      Re: [PATCH v2 2/7] dt-bindings: pinctrl: Add RZ/A1 bindings doc jacopo <jacopo@jmondi.org> - 2017-03-23 17:10 +0100
  RE: [PATCH v2 0/7] Renesas RZ/A1 pin and gpio controller Chris Brandt <Chris.Brandt@renesas.com> - 2017-03-22 19:20 +0100

csiph-web