Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1606532
| Path | csiph.com!news.freedyn.net!open-news-network.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arnd Bergmann <arnd@arndb.de> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] x86: s/READ_ONCE_NOCHECK/READ_ONCE/ in arch_atomic[64]_read() |
| Date | Wed, 22 Mar 2017 15:20:01 +0100 |
| Message-ID | <tnPhf-3Fu-11@gated-at.bofh.it> (permalink) |
| References | <tnO1Q-2wP-29@gated-at.bofh.it> |
| X-Original-To | Dmitry Vyukov <dvyukov@google.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=f6Ku+8QY74hdvNbj2fSpcHvnEI2j3Hy+/t+cTYV2Tsk=; b=Hvgb6gkQg2f/hkdigdTYBsljP/7aXBlK9kY+3tUqmSuOx0aa6yj8DfCOfBLR45grVb Bb5EJthqFolgNvGGRTjCyFGaYOw50M2VqC5Ul5TiNX5dte4rPMFniE9APuyQhh+4iyz2 Kyx+pzWGI3sytpbp+6LIY1HZ6riLsof5vamWmSwWLilM3DKUGFE8wTul3BFrrJ/U9KoO e8ITLg8+RVCL/OmDqGKCKYA5srjGVNwZTF06mAOYkjDV4wp4SZt6Kp18ty5cIAzaIxsc RcH07zbNO/NT+2+jX+WVDERv9pzQMBXfOdgRjSowiVyzWJ8C1GE13LF00XwRpcEVbfa4 cNVA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=f6Ku+8QY74hdvNbj2fSpcHvnEI2j3Hy+/t+cTYV2Tsk=; b=XsOl3M9ZNNtkXR6w4EkoBn1qKGQ265GHzhtNt4uFU+vKAh8ckpMBiGJpkxFVnhqYBH n0ETJb0CmrpNdVpo7uhSLJ/PK6UJ3Qx8Gzz4TNg6S2t31IrKPrFxNC3rUS7zEOhimY4d 6Q58W+3qgbqGliqLd2oTdGVQr6VA4KHXTEHtEVdsSCWL2ZT+MLqD1/FFVzBk7iBFN6Ag Z8w9cD8t5E5m4+HwUJmPdbu/Los/rOVJ4VObNS2y5wseyfzp2EAP8ZFOsUfwscNihZlz 8dbOqtvSQIVo0HeoUmDvsSRN+MLeWazw0g6pTYV0UhDRWbVwZvlSOyPVy2F6cQNmYNNz Rtbg== |
| X-Gm-Message-State | AFeK/H0AfjLupQUqzGLJ6TjIFUEOZr0I87CgvARP3KLcj7gYL1/BHkWI9pJrrY669rTR/0Mcp/LAH23wQONnCg== |
| X-Received | by 10.202.172.210 with SMTP id v201mr19466973oie.136.1490191981165; Wed, 22 Mar 2017 07:13:01 -0700 (PDT) |
| MIME-Version | 1.0 |
| X-Google-Sender-Auth | 46xQWuK7Xryu1gQgYavrvUfkVUY |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 28 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Andrew Morton <akpm@linux-foundation.org>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Mark Rutland <mark.rutland@arm.com>, Peter Zijlstra <peterz@infradead.org>, Will Deacon <will.deacon@arm.com>, Linux-MM <linux-mm@kvack.org>, x86@kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, kasan-dev <kasan-dev@googlegroups.com> |
| X-Original-Date | Wed, 22 Mar 2017 15:13:00 +0100 |
| X-Original-Message-ID | <CAK8P3a2NdyBRciYh9_N0wq8B_u0uS+3HwiSqKYe5ez5uZdwkiQ@mail.gmail.com> |
| X-Original-References | <20170322125740.85337-1-dvyukov@google.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1606532 |
Show key headers only | View raw
On Wed, Mar 22, 2017 at 1:57 PM, Dmitry Vyukov <dvyukov@google.com> wrote: > Two problems was reported with READ_ONCE_NOCHECK in arch_atomic_read: > 1. Andrey Ryabinin reported significant binary size increase > (+400K of text). READ_ONCE_NOCHECK is intentionally compiled to > non-inlined function call, and I counted 640 copies of it in my vmlinux. > 2. Arnd Bergmann reported a new splat of too large frame sizes. > > A single inlined KASAN check is very cheap, a non-inlined function > call with KASAN/KCOV instrumentation can easily be more expensive. > > Switch to READ_ONCE() in arch_atomic[64]_read(). > > Signed-off-by: Dmitry Vyukov <dvyukov@google.com> > Reported-by: Arnd Bergmann <arnd@arndb.de> > Reported-by: Andrey Ryabinin <aryabinin@virtuozzo.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: linux-mm@kvack.org > Cc: x86@kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: kasan-dev@googlegroups.com > Signed-off-by: Dmitry Vyukov <dvyukov@google.com> > Acked-by: Arnd Bergmann <arnd@arndb.de>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] x86: s/READ_ONCE_NOCHECK/READ_ONCE/ in arch_atomic[64]_read() Dmitry Vyukov <dvyukov@google.com> - 2017-03-22 14:00 +0100 Re: [PATCH v2] x86: s/READ_ONCE_NOCHECK/READ_ONCE/ in arch_atomic[64]_read() Arnd Bergmann <arnd@arndb.de> - 2017-03-22 15:20 +0100 Re: [PATCH v2] x86: s/READ_ONCE_NOCHECK/READ_ONCE/ in arch_atomic[64]_read() Ingo Molnar <mingo@kernel.org> - 2017-03-27 08:30 +0200
csiph-web