Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1606617
| From | Jarkko Nikula <jarkko.nikula@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions |
| Date | 2017-03-22 16:00 +0100 |
| Message-ID | <tnPTY-3ZD-21@gated-at.bofh.it> (permalink) |
| References | <tn3vY-3VF-13@gated-at.bofh.it> <tn3FD-3Z3-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 03/20/17 13:10, Luis Oliveira wrote:
> - Definitions were added to core library
> - A example was added to designware-core.txt Documentation that shows
> how the slave can be setup using DTS
>
> SLAVE related definitions were added to the core of the controller.
>
> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> v6-v7
> - no changes
>
...
> +#define DW_IC_RX_ABRT_SLAVE_RD_INTX (1UL << ABRT_SLAVE_RD_INTX)
> +#define DW_IC_RX_ABRT_SLAVE_ARBLOST (1UL << ABRT_SLAVE_ARBLOST)
> +#define DW_IC_RX_ABRT_SLAVE_FLUSH_TXFIFO (1UL << ABRT_SLAVE_FLUSH_TXFIFO)
>
> #define DW_IC_TX_ABRT_NOACK (DW_IC_TX_ABRT_7B_ADDR_NOACK | \
> DW_IC_TX_ABRT_10ADDR1_NOACK | \
> @@ -211,6 +236,7 @@ struct dw_i2c_dev {
> struct completion cmd_complete;
> struct clk *clk;
> struct reset_control *rst;
> + struct i2c_client *slave;
> u32 (*get_clk_rate_khz) (struct dw_i2c_dev *dev);
> struct dw_pci_controller *controller;
> int cmd_err;
> @@ -230,6 +256,7 @@ struct dw_i2c_dev {
> struct i2c_adapter adapter;
> u32 functionality;
> u32 master_cfg;
> + u32 slave_cfg;
> unsigned int tx_fifo_depth;
> unsigned int rx_fifo_depth;
> int rx_outstanding;
>
Here too I take my ack back. You should add comments for these added
members.
--
Jarkko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v7 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:20 +0100
[PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:30 +0100
Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-22 15:50 +0100
Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-22 16:00 +0100
[PATCH v7 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:30 +0100
Re: [PATCH v7 5/6] i2c: designware: add SLAVE mode functions Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-22 16:10 +0100
[PATCH v7 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:30 +0100
[PATCH v7 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:30 +0100
Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-22 15:50 +0100
Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-22 16:10 +0100
Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-22 16:00 +0100
[PATCH v7 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:30 +0100
csiph-web