Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1606611

Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver

Show all headers | View raw

On 03/20/17 13:10, Luis Oliveira wrote:
> - The functions related to I2C master mode of operation were transformed
>   in a single driver.
> - Common definitions were moved to i2c-designware-core.h
> - The i2c-designware-core is now only a library file, the functions
>   associated are in a source file called i2c-designware-common and
>   are used by both i2c-designware-master and i2c-designware-slave.
> - To decrease noise in namespace common i2c_dw_*() functions are
>   now using ops to keep them private.
> - Designware PCI driver had to be changed to match the previous ops
>   functions implementation.
>
> Almost all of the "core" source is now part of the "master" source. The
> difference is the functions used by both modes and they are in the
> "common" source file.
>
> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v6-v7
> - Moved kernel doc comments from patch 4/6 to this patch. @Jarkko
> - Fix Designware I2C PCI driver error when looking for previous extern
>   functions.
>
>  drivers/i2c/busses/Makefile                        |   1 +
>  drivers/i2c/busses/i2c-designware-common.c         | 274 +++++++++++++++
>  drivers/i2c/busses/i2c-designware-core.h           | 146 +++++++-
>  ...c-designware-core.c => i2c-designware-master.c} | 367 +--------------------
>  drivers/i2c/busses/i2c-designware-pcidrv.c         |   8 +-
>  drivers/i2c/busses/i2c-designware-platdrv.c        |   6 +-
>  6 files changed, 433 insertions(+), 369 deletions(-)
>  create mode 100644 drivers/i2c/busses/i2c-designware-common.c
>  rename drivers/i2c/busses/{i2c-designware-core.c => i2c-designware-master.c} (64%)
>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:20 +0100
  [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:30 +0100
    Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-22 15:50 +0100
    Re: [PATCH v7 4/6] i2c: designware: introducing I2C_SLAVE definitions Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-22 16:00 +0100
  [PATCH v7 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:30 +0100
    Re: [PATCH v7 5/6] i2c: designware: add SLAVE mode functions Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-22 16:10 +0100
  [PATCH v7 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:30 +0100
  [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:30 +0100
    Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-22 15:50 +0100
      Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-22 16:10 +0100
    Re: [PATCH v7 3/6] i2c: designware: MASTER mode as separated driver Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-03-22 16:00 +0100
  [PATCH v7 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-03-20 12:30 +0100

csiph-web