Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604771

Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning

Show all headers | View raw

On Mon, Mar 20, 2017 at 4:05 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Mon, 20 Mar 2017 10:32:19 +0100
> Arnd Bergmann <arnd@arndb.de> wrote:
>
>> -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/)
>> +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void)
>>  {
> Why keep the comment?

The comment matches one later in the file when this function gets called.

I thought about cleaning up both at the same time, but couldn't figure out
how the comment ended up in there or why it was left behind in the first
place, so I ended up leaving both for another patch on top. If you prefer,
I could resend the patch and do both at once.

        Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/9] staging/atomisp: include linux/io.h where needed Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:40 +0100
  [PATCH 6/9] staging/atomisp: add PCI dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:40 +0100
  [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning Arnd Bergmann <arnd@arndb.de> - 2017-03-20 11:00 +0100
    Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning Stephen Hemminger <stephen@networkplumber.org> - 2017-03-20 16:10 +0100
      Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning Arnd Bergmann <arnd@arndb.de> - 2017-03-20 17:40 +0100
  [PATCH 2/9] staging/atomisp: fix empty-body warning Arnd Bergmann <arnd@arndb.de> - 2017-03-20 11:00 +0100
  [PATCH 7/9] staging/atomisp: add ACPI dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-20 11:00 +0100
  [PATCH 5/9] staging/atomisp: add VIDEO_V4L2_SUBDEV_API dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-20 13:50 +0100
  [PATCH 9/9] staging/atomisp: add EFI dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-20 13:50 +0100
  [PATCH 8/9] staging/atomisp: add MEDIA_CONTROLLER dependency globally Arnd Bergmann <arnd@arndb.de> - 2017-03-20 13:50 +0100

csiph-web