Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604287

[PATCH 6/9] staging/atomisp: add PCI dependency

Show all headers | View raw

Without CONFIG_PCI, config space reads never return any data,
leading to undefined behavior that gcc warns about:

platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32_raw':
platform/intel-mid/intel_mid_pcihelpers.c:66:9: error: 'data' is used uninitialized in this function [-Werror=uninitialized]
platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32_raw_ext':
platform/intel-mid/intel_mid_pcihelpers.c:84:9: error: 'data' is used uninitialized in this function [-Werror=uninitialized]
platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32':
platform/intel-mid/intel_mid_pcihelpers.c:137:9: error: 'data' is used uninitialized in this function [-Werror=uninitialized]

With a dependency on CONFIG_PCI, we don't get this warning. This seems
safe as PCI config space accessors should always return something
when PCI is enabled.

Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/staging/media/atomisp/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig
index f7d8a841c629..3af2acdc7e96 100644
--- a/drivers/staging/media/atomisp/Kconfig
+++ b/drivers/staging/media/atomisp/Kconfig
@@ -1,6 +1,6 @@
 menuconfig INTEL_ATOMISP
         bool "Enable support to Intel MIPI camera drivers"
-        depends on X86
+        depends on X86 && PCI
         help
           Enable support for the Intel ISP2 camera interfaces and MIPI
           sensor drivers.
-- 
2.9.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/9] staging/atomisp: include linux/io.h where needed Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:40 +0100
  [PATCH 6/9] staging/atomisp: add PCI dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:40 +0100
  [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning Arnd Bergmann <arnd@arndb.de> - 2017-03-20 11:00 +0100
    Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning Stephen Hemminger <stephen@networkplumber.org> - 2017-03-20 16:10 +0100
      Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning Arnd Bergmann <arnd@arndb.de> - 2017-03-20 17:40 +0100
  [PATCH 2/9] staging/atomisp: fix empty-body warning Arnd Bergmann <arnd@arndb.de> - 2017-03-20 11:00 +0100
  [PATCH 7/9] staging/atomisp: add ACPI dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-20 11:00 +0100
  [PATCH 5/9] staging/atomisp: add VIDEO_V4L2_SUBDEV_API dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-20 13:50 +0100
  [PATCH 9/9] staging/atomisp: add EFI dependency Arnd Bergmann <arnd@arndb.de> - 2017-03-20 13:50 +0100
  [PATCH 8/9] staging/atomisp: add MEDIA_CONTROLLER dependency globally Arnd Bergmann <arnd@arndb.de> - 2017-03-20 13:50 +0100

csiph-web