Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1604388

Re: [PATCH] soc/tegra: fix link errors with PMC disabled

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Mar 20, 2017 at 09:47:39AM +0000, Jon Hunter wrote:
> Hi Arnd,
> 
> On 20/03/17 09:13, Arnd Bergmann wrote:
> > With the new Tegra186 PMC driver merged, anything that relies on the previous
> > PMC driver fails to link when that is disabled:
> > 
> > arch/arm/mach-tegra/pm.o: In function `tegra_pm_set':
> > pm.c:(.text.tegra_pm_set+0x3c): undefined reference to `tegra_pmc_enter_suspend_mode'
> > arch/arm/mach-tegra/pm.o: In function `tegra_suspend_enter':
> > pm.c:(.text.tegra_suspend_enter+0x4): undefined reference to `tegra_pmc_get_suspend_mode'
> > arch/arm/mach-tegra/pm.o: In function `tegra_init_suspend':
> > pm.c:(.init.text+0x1c): undefined reference to `tegra_pmc_get_suspend_mode'
> > pm.c:(.init.text+0x74): undefined reference to `tegra_pmc_set_suspend_mode'
> > 
> > ERROR: tegra_powergate_sequence_power_up [drivers/ata/ahci_tegra.ko] undefined!
> > ERROR: tegra_powergate_power_off [drivers/ata/ahci_tegra.ko] undefined!
> > 
> > Making the definition depend on the presence of the driver makes it build
> > again, though that might not be the correct fix.
> > 
> > Fixes: 854014236290 ("soc/tegra: Implement Tegra186 PMC support")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> A fix was also submitted by Krzysztof [0].
> 
> Thierry, what's your preference? Maybe Arnd's approach is better.

Yes, I prefer Arnd's patch because it is more consistent with how we
deal with this kind of dependency elsewhere.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] soc/tegra: fix link errors with PMC disabled Arnd Bergmann <arnd@arndb.de> - 2017-03-20 10:30 +0100
  Re: [PATCH] soc/tegra: fix link errors with PMC disabled Jon Hunter <jonathanh@nvidia.com> - 2017-03-20 11:00 +0100
    Re: [PATCH] soc/tegra: fix link errors with PMC disabled Thierry Reding <thierry.reding@gmail.com> - 2017-03-20 12:20 +0100
  Re: [PATCH] soc/tegra: fix link errors with PMC disabled Thierry Reding <thierry.reding@gmail.com> - 2017-03-20 13:50 +0100

csiph-web