Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1603769

Re: [PATCH v1 3/3] blk-mq: start to freeze queue just after setting dying

Show all headers | View raw

On 03/17/2017 10:57 AM, Ming Lei wrote:
> Before commit 780db2071a(blk-mq: decouble blk-mq freezing
> from generic bypassing), the dying flag is checked before
> entering queue, and Tejun converts the checking into .mq_freeze_depth,
> and assumes the counter is increased just after dying flag
> is set. Unfortunately we doesn't do that in blk_set_queue_dying().
> 
> This patch calls blk_mq_freeze_queue_start() for blk-mq in
> blk_set_queue_dying(), so that we can block new I/O coming
> once the queue is set as dying.
> 
> Given blk_set_queue_dying() is always called in remove path
> of block device, and queue will be cleaned up later, we don't
> need to worry about undoing the counter.
> 
> Cc: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
>  block/blk-core.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/3] blk-mq: dying queue fix & improvement Ming Lei <tom.leiming@gmail.com> - 2017-03-17 11:10 +0100
  [PATCH v1 1/3] blk-mq: don't complete un-started request in timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-17 11:10 +0100
    Re: [PATCH v1 1/3] blk-mq: don't complete un-started request in  timeout handler Hannes Reinecke <hare@suse.de> - 2017-03-18 12:30 +0100
  [PATCH v1 3/3] blk-mq: start to freeze queue just after setting dying Ming Lei <tom.leiming@gmail.com> - 2017-03-17 11:10 +0100
    Re: [PATCH v1 3/3] blk-mq: start to freeze queue just after setting dying Ming Lei <tom.leiming@gmail.com> - 2017-03-17 19:50 +0100
    Re: [PATCH v1 3/3] blk-mq: start to freeze queue just after setting  dying Ming Lei <tom.leiming@gmail.com> - 2017-03-18 02:10 +0100
    Re: [PATCH v1 3/3] blk-mq: start to freeze queue just after setting  dying Hannes Reinecke <hare@suse.de> - 2017-03-18 12:50 +0100
  [PATCH v1 2/3] blk-mq: comment on races related with timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-17 11:10 +0100
    Re: [PATCH v1 2/3] blk-mq: comment on races related with timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-17 19:30 +0100
    Re: [PATCH v1 2/3] blk-mq: comment on races related with timeout  handler Hannes Reinecke <hare@suse.de> - 2017-03-18 12:30 +0100

csiph-web