Re: [PATCH v1 2/3] blk-mq: comment on races related with timeout handler

From	Hannes Reinecke <hare@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1 2/3] blk-mq: comment on races related with timeout handler
Date	2017-03-18 12:30 +0100
Message-ID	<tmkIx-5uP-3@gated-at.bofh.it> (permalink)
References	<tlWZz-4Iy-3@gated-at.bofh.it> <tlWZz-4Iy-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/17/2017 10:57 AM, Ming Lei wrote:
> This patch adds comment on two races related with
> timeout handler:
> 
> - requeue from queue busy vs. timeout
> - rq free & reallocation vs. timeout
> 
> Both the races themselves and current solution aren't
> explicit enough, so add comments on them.
> 
> Cc: Bart Van Assche <bart.vanassche@sandisk.com>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
>  block/blk-mq.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 

Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/3] blk-mq: dying queue fix & improvement Ming Lei <tom.leiming@gmail.com> - 2017-03-17 11:10 +0100
  [PATCH v1 1/3] blk-mq: don't complete un-started request in timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-17 11:10 +0100
    Re: [PATCH v1 1/3] blk-mq: don't complete un-started request in  timeout handler Hannes Reinecke <hare@suse.de> - 2017-03-18 12:30 +0100
  [PATCH v1 3/3] blk-mq: start to freeze queue just after setting dying Ming Lei <tom.leiming@gmail.com> - 2017-03-17 11:10 +0100
    Re: [PATCH v1 3/3] blk-mq: start to freeze queue just after setting dying Ming Lei <tom.leiming@gmail.com> - 2017-03-17 19:50 +0100
    Re: [PATCH v1 3/3] blk-mq: start to freeze queue just after setting  dying Ming Lei <tom.leiming@gmail.com> - 2017-03-18 02:10 +0100
    Re: [PATCH v1 3/3] blk-mq: start to freeze queue just after setting  dying Hannes Reinecke <hare@suse.de> - 2017-03-18 12:50 +0100
  [PATCH v1 2/3] blk-mq: comment on races related with timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-17 11:10 +0100
    Re: [PATCH v1 2/3] blk-mq: comment on races related with timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-17 19:30 +0100
    Re: [PATCH v1 2/3] blk-mq: comment on races related with timeout  handler Hannes Reinecke <hare@suse.de> - 2017-03-18 12:30 +0100

csiph-web