Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1603749

Re: [PATCH] x86/microcode/AMD: remove redundant null check on mc

From Borislav Petkov <bp@alien8.de>
Newsgroups linux.kernel
Subject Re: [PATCH] x86/microcode/AMD: remove redundant null check on mc
Date 2017-03-18 10:40 +0100
Message-ID <tmj05-4dN-1@gated-at.bofh.it> (permalink)
References <tlkKC-2iu-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Mar 15, 2017 at 05:10:10PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> mc is a pointer to the static u8 array amd_ucode_patch and
> therefore can never be null, so the check is redundant. Remove it.
> 
> Detected by CoverityScan, CID#1372871 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  arch/x86/kernel/cpu/microcode/amd.c | 3 ---
>  1 file changed, 3 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] x86/microcode/AMD: remove redundant null check on mc Colin King <colin.king@canonical.com> - 2017-03-15 18:20 +0100
  Re: [PATCH] x86/microcode/AMD: remove redundant null check on mc Borislav Petkov <bp@alien8.de> - 2017-03-18 10:40 +0100
  [tip:x86/microcode] x86/microcode/AMD: Remove redundant NULL check  on mc tip-bot for Colin Ian King <tipbot@zytor.com> - 2017-03-18 16:50 +0100

csiph-web