[PATCH] x86/microcode/AMD: remove redundant null check on mc

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] x86/microcode/AMD: remove redundant null check on mc
Date	2017-03-15 18:20 +0100
Message-ID	<tlkKC-2iu-27@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

mc is a pointer to the static u8 array amd_ucode_patch and
therefore can never be null, so the check is redundant. Remove it.

Detected by CoverityScan, CID#1372871 ("Logically Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 arch/x86/kernel/cpu/microcode/amd.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
index 7889ae4..f2afe99 100644
--- a/arch/x86/kernel/cpu/microcode/amd.c
+++ b/arch/x86/kernel/cpu/microcode/amd.c
@@ -352,9 +352,6 @@ void reload_ucode_amd(void)
 	u32 rev, dummy;
 
 	mc = (struct microcode_amd *)amd_ucode_patch;
-	if (!mc)
-		return;
-
 	rdmsr(MSR_AMD64_PATCH_LEVEL, rev, dummy);
 
 	if (rev < mc->hdr.patch_id) {
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/microcode/AMD: remove redundant null check on mc Colin King <colin.king@canonical.com> - 2017-03-15 18:20 +0100
  Re: [PATCH] x86/microcode/AMD: remove redundant null check on mc Borislav Petkov <bp@alien8.de> - 2017-03-18 10:40 +0100
  [tip:x86/microcode] x86/microcode/AMD: Remove redundant NULL check  on mc tip-bot for Colin Ian King <tipbot@zytor.com> - 2017-03-18 16:50 +0100

csiph-web