Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601927

[mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

Show all headers | View raw

Hello,

commit 4f86a82ff7df ("x86/atomic: move __arch_atomic_add_unless out of line")
moved __arch_atomic_add_unless() out atomic.h and new KASAN atomic
instrumentation [1] can't see it anymore


In file included from ./arch/x86/include/asm/atomic.h:257:0,
                 from ./include/linux/atomic.h:4,
                 from ./include/asm-generic/qspinlock_types.h:28,
                 from ./arch/x86/include/asm/spinlock_types.h:26,
                 from ./include/linux/spinlock_types.h:13,
                 from kernel/bounds.c:13:
./include/asm-generic/atomic-instrumented.h: In function ‘__atomic_add_unless’:
./include/asm-generic/atomic-instrumented.h:70:9: error: implicit declaration of function ‘__arch_atomic_add_unless’ [-Werror=implicit-function-declaration]
  return __arch_atomic_add_unless(v, a, u);
         ^~~~~~~~~~~~~~~~~~~~~~~~


so we need a declaration of __arch_atomic_add_unless() in arch/x86/include/asm/atomic.h


[1] lkml.kernel.org/r/7e450175a324bf93c602909c711bc34715d8e8f2.1489519233.git.dvyukov@google.com

	-ss

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[mmotm] "x86/atomic: move __arch_atomic_add_unless out of line"  build error Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-16 05:50 +0100
  Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line"  build error Dmitry Vyukov <dvyukov@google.com> - 2017-03-16 09:30 +0100
    Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line"  build error Andi Kleen <ak@linux.intel.com> - 2017-03-16 17:30 +0100
    Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line"  build error Andi Kleen <ak@linux.intel.com> - 2017-03-16 17:50 +0100
      Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line"  build error Andrew Morton <akpm@linux-foundation.org> - 2017-03-16 19:50 +0100

csiph-web