Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601375

Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler

From Ming Lei <tom.leiming@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler
Date 2017-03-15 13:50 +0100
Message-ID <tlgxj-7FO-11@gated-at.bofh.it> (permalink)
References <tj5Zo-5Ce-41@gated-at.bofh.it> <tj693-5FN-13@gated-at.bofh.it> <tlgdY-7yR-13@gated-at.bofh.it> <tlgdY-7yR-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 15, 2017 at 08:18:53PM +0800, Ming Lei wrote:
> On Wed, Mar 15, 2017 at 12:07:37AM +0000, Bart Van Assche wrote:
> 
> > or __blk_mq_requeue_request(). Another issue with this function is that the
> 
> __blk_mq_requeue_request() can be run from two pathes:
> 
> 	- dispatch failure, in which case the req/tag isn't released to tag set
> 	
> 	- IO completion path, in which COMPLETE flag is cleared before requeue.
> 	
> so I can't see races with timeout in case of start rq vs. requeue rq. 

Actually rq/tag won't be released to tag set if it will be requeued, so
the timeout race is nothing to do with requeue.

Thanks,
Ming

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout  handler Ming Lei <tom.leiming@gmail.com> - 2017-03-15 13:30 +0100
  Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout  handler Ming Lei <tom.leiming@gmail.com> - 2017-03-15 13:50 +0100
    Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout  handler Ming Lei <tom.leiming@gmail.com> - 2017-03-15 17:30 +0100
      Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout  handler Ming Lei <tom.leiming@gmail.com> - 2017-03-15 17:50 +0100
      Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout  handler Ming Lei <tom.leiming@gmail.com> - 2017-03-16 01:10 +0100
        Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-17 01:10 +0100
  Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout  handler Ming Lei <tom.leiming@gmail.com> - 2017-03-16 00:50 +0100

csiph-web