Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1602923
| From | Ming Lei <tom.leiming@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler |
| Date | 2017-03-17 01:10 +0100 |
| Message-ID | <tlNCV-63z-9@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <tljYd-1Jv-3@gated-at.bofh.it> <tljYd-1Jv-1@gated-at.bofh.it> <tlr9o-6R3-7@gated-at.bofh.it> <tlr9o-6R3-5@gated-at.bofh.it> <tlNCV-63z-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Mar 17, 2017 at 5:35 AM, Bart Van Assche <Bart.VanAssche@sandisk.com> wrote: > On Thu, 2017-03-16 at 08:07 +0800, Ming Lei wrote: >> > * Check whether REQ_ATOM_STARTED has been set. >> > * Check whether REQ_ATOM_COMPLETE has not yet been set. >> > * If both conditions have been met, set REQ_ATOM_COMPLETE. >> > >> > I don't think there is another solution than using a single state variable to >> > represent the REQ_ATOM_STARTED and REQ_ATOM_COMPLETE states instead of two >> > independent bits. How about the patch below? >> >> I would review it if you can confirm me that it is a real issue, :-) > > Hello Ming, > > I was chasing a v4.11 regression in the SCSI stack. Since my tests of today > revealed that it's probably not a block layer issue, let's proceed with your > patch. Yeah, it shouldn't have been related with blk-mq timeout handler which isn't changed much recently, and thanks for your review! Thanks, Ming Lei
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-15 13:30 +0100
Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-15 13:50 +0100
Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-15 17:30 +0100
Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-15 17:50 +0100
Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-16 01:10 +0100
Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-17 01:10 +0100
Re: [PATCH 1/2] blk-mq: don't complete un-started request in timeout handler Ming Lei <tom.leiming@gmail.com> - 2017-03-16 00:50 +0100
csiph-web