Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1601230

Re: [PATCH v4 4/5] mfd: exynos-lpass: Use common soc/exynos-regs-pmu.h header

Show all headers | View raw

On Tue, 14 Mar 2017, Krzysztof Kozlowski wrote:

> The MFD-specific header will go away because it duplicates defines from
> exynos-regs-pmu.h.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
>  drivers/mfd/exynos-lpass.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c
> index 2e064fb8826f..8bebad92a385 100644
> --- a/drivers/mfd/exynos-lpass.c
> +++ b/drivers/mfd/exynos-lpass.c
> @@ -18,11 +18,11 @@
>  #include <linux/io.h>
>  #include <linux/module.h>
>  #include <linux/mfd/syscon.h>
> -#include <linux/mfd/syscon/exynos5-pmu.h>
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
>  #include <linux/platform_device.h>
>  #include <linux/regmap.h>
> +#include <linux/soc/samsung/exynos-regs-pmu.h>
>  #include <linux/types.h>
>  
>  /* LPASS Top register definitions */
> @@ -83,7 +83,7 @@ static void exynos_lpass_enable(struct exynos_lpass *lpass)
>  
>  	/* Activate related PADs from retention state */
>  	regmap_write(lpass->pmu, EXYNOS5433_PAD_RETENTION_AUD_OPTION,
> -		     EXYNOS5433_PAD_INITIATE_WAKEUP_FROM_LOWPWR);
> +		     EXYNOS_WAKEUP_FROM_LOWPWR);
>  
>  	exynos_lpass_core_sw_reset(lpass, LPASS_I2S_SW_RESET);
>  	exynos_lpass_core_sw_reset(lpass, LPASS_DMA_SW_RESET);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/5] phy/mfd/soc: exynos: Header cleanup Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 17:50 +0100
  [PATCH v4 1/5] phy: exynos4: Remove duplicated defines of PHY register defines Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 17:50 +0100
  [PATCH v4 3/5] phy: exynos-mipi-video: Use consistent method to address phy registers Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 17:50 +0100
  [PATCH v4 4/5] mfd: exynos-lpass: Use common soc/exynos-regs-pmu.h header Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 17:50 +0100
    Re: [PATCH v4 4/5] mfd: exynos-lpass: Use common  soc/exynos-regs-pmu.h header Lee Jones <lee.jones@linaro.org> - 2017-03-15 11:20 +0100
      Re: [PATCH v4 4/5] mfd: exynos-lpass: Use common soc/exynos-regs-pmu.h  header Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-15 12:10 +0100
        Re: [PATCH v4 4/5] mfd: exynos-lpass: Use common  soc/exynos-regs-pmu.h header Lee Jones <lee.jones@linaro.org> - 2017-03-15 13:20 +0100
          Re: [PATCH v4 4/5] mfd: exynos-lpass: Use common soc/exynos-regs-pmu.h  header Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-15 14:20 +0100
    [GIT PULL] Immutable branch between MFD and PHY due for the v4.12  merge window Lee Jones <lee.jones@linaro.org> - 2017-03-23 12:00 +0100
      Re: [GIT PULL] Immutable branch between MFD and PHY due for the v4.12  merge window Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-23 13:00 +0100
      Re: [GIT PULL] Immutable branch between MFD and PHY due for the v4.12  merge window Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-27 15:30 +0200
  [PATCH v4 5/5] phy: exynos: Use one define for enable bit Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 17:50 +0100
  Re: [PATCH v4 0/5] phy/mfd/soc: exynos: Header cleanup Kishon Vijay Abraham I <kishon@ti.com> - 2017-03-27 15:30 +0200

csiph-web