Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks
Date	2017-03-17 08:40 +0100
Message-ID	<tlUEq-2QJ-11@gated-at.bofh.it> (permalink)
References	<tlsI9-7Ou-3@gated-at.bofh.it> <tlsI9-7Ou-9@gated-at.bofh.it> <tlBiq-5vO-19@gated-at.bofh.it> <tlKlI-3E4-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 16-03-17 13:32:23, Joe Perches wrote:
> On Thu, 2017-03-16 at 11:56 +0100, Michal Hocko wrote:
> > On Wed 15-03-17 18:43:13, Joe Perches wrote:
> > > Function calls with large argument counts cause x86-64 register
> > > spilling.  Reducing the number of arguments in a multi-line printk
> > > by converting to multiple printks which saves some object code size.
> > > 
> > > $ size mm/page_alloc.o* (defconfig)
> > >    text    data     bss     dec     hex filename
> > >   35914	   1699	    628	  38241	   9561	mm/page_alloc.o.new
> > >   36018    1699     628   38345    95c9 mm/page_alloc.o.old
> > > 
> > > Miscellanea:
> > > 
> > > o Remove line leading spaces from the formerly multi-line printks
> > >   commit a25700a53f71 ("mm: show bounce pages in oom killer output")
> > >   back in 2007 started the leading space when a single long line
> > >   was split into multiple lines but the leading space was likely
> > >   mistakenly kept and subsequent commits followed suit.
> > > o Align arguments in a few more printks
> > 
> > This is really hard to review. Could you just drop all the whitespace
> > changes please?
> 
> It's a single, simple change. 

no it adds a lot of whitespace noise to an actual change. It takes to
check every single line to see whether some typo or unintended change
has been made.

> It's IMO trivial to review.

it's not IMNSHO.
-- 
Michal Hocko
SUSE Labs

Thread

[PATCH 0/3] mm: page_alloc: Object code reductions and logging fix Joe Perches <joe@perches.com> - 2017-03-16 02:50 +0100
  [PATCH 2/3] mm: page_alloc: Fix misordered logging output, reduce code size Joe Perches <joe@perches.com> - 2017-03-16 02:50 +0100
    Re: [PATCH 2/3] mm: page_alloc: Fix misordered logging output,  reduce code size Michal Hocko <mhocko@kernel.org> - 2017-03-16 12:00 +0100
  [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Joe Perches <joe@perches.com> - 2017-03-16 02:50 +0100
    Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening  printks Michal Hocko <mhocko@kernel.org> - 2017-03-16 12:00 +0100
      Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening  printks Joe Perches <joe@perches.com> - 2017-03-16 21:40 +0100
        Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening  printks Michal Hocko <mhocko@kernel.org> - 2017-03-17 08:40 +0100
    Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening  printks Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-16 12:40 +0100
      Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening  printks Joe Perches <joe@perches.com> - 2017-03-16 19:40 +0100
        Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening  printks Andrew Morton <akpm@linux-foundation.org> - 2017-03-17 00:00 +0100
        Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening  printks Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-17 03:10 +0100
          Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening  printks Joe Perches <joe@perches.com> - 2017-03-18 20:40 +0100
            Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening  printks Petr Mladek <pmladek@suse.com> - 2017-03-20 14:30 +0100

csiph-web