Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1602905
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks |
| Date | 2017-03-17 00:00 +0100 |
| Message-ID | <tlMxb-56x-1@gated-at.bofh.it> (permalink) |
| References | <tlsI9-7Ou-3@gated-at.bofh.it> <tlsI9-7Ou-9@gated-at.bofh.it> <tlBV7-62w-1@gated-at.bofh.it> <tlItA-2iT-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 16 Mar 2017 11:37:56 -0700 Joe Perches <joe@perches.com> wrote:
> > this can make it harder to read, in _the worst case_. one printk()
> > guaranteed that we would see a single line in the serial log/etc.
> > the sort of a problem with multiple printks is that printks coming
> > from other CPUs will split that "previously single" line.
>
> Not true. Note the multiple \n uses in the original code.
hm? Won't printk("a\na") atomically emit all three chars into the log
buffer?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] mm: page_alloc: Object code reductions and logging fix Joe Perches <joe@perches.com> - 2017-03-16 02:50 +0100
[PATCH 2/3] mm: page_alloc: Fix misordered logging output, reduce code size Joe Perches <joe@perches.com> - 2017-03-16 02:50 +0100
Re: [PATCH 2/3] mm: page_alloc: Fix misordered logging output, reduce code size Michal Hocko <mhocko@kernel.org> - 2017-03-16 12:00 +0100
[PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Joe Perches <joe@perches.com> - 2017-03-16 02:50 +0100
Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Michal Hocko <mhocko@kernel.org> - 2017-03-16 12:00 +0100
Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Joe Perches <joe@perches.com> - 2017-03-16 21:40 +0100
Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Michal Hocko <mhocko@kernel.org> - 2017-03-17 08:40 +0100
Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-16 12:40 +0100
Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Joe Perches <joe@perches.com> - 2017-03-16 19:40 +0100
Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Andrew Morton <akpm@linux-foundation.org> - 2017-03-17 00:00 +0100
Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-03-17 03:10 +0100
Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Joe Perches <joe@perches.com> - 2017-03-18 20:40 +0100
Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening printks Petr Mladek <pmladek@suse.com> - 2017-03-20 14:30 +0100
csiph-web