Re: [PATCH] vc04_services: Fixing coding and logical guidelines

From	Pushkar Jambhlekar <pushkar.iit@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] vc04_services: Fixing coding and logical guidelines
Date	2017-03-15 06:10 +0100
Message-ID	<tl9m9-2KE-3@gated-at.bofh.it> (permalink)
References	<tl7No-1AG-9@gated-at.bofh.it> <tl9cu-2sb-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Thanks. I will rewrite patch according to the suggestions.

On Tue, Mar 14, 2017 at 9:52 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
>> Description:
>
> No need for that line.
>
>>     in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'.
>
> Why indent?  Also, you need to be specific as to what type of changes
> you made.
>
>> Also, fixing logical issue, i.e. removing break after goto statement.
>
> Don't do multiple things in the same patch, break it up into
> one-patch-per-thing, and no, "checkpatch.pl cleanups" is not "one
> thing" :)
>
> thanks,
>
> greg k-h



-- 
Jambhlekar Pushkar Arun
M.Tech IIT Roorkee

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] vc04_services: Fixing coding and logical guidelines Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-15 04:30 +0100
  Re: [PATCH] vc04_services: Fixing coding and logical guidelines Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-15 06:00 +0100
    Re: [PATCH] vc04_services: Fixing coding and logical guidelines Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-15 06:10 +0100

csiph-web