Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1601052
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] vc04_services: Fixing coding and logical guidelines |
| Date | 2017-03-15 06:00 +0100 |
| Message-ID | <tl9cu-2sb-7@gated-at.bofh.it> (permalink) |
| References | <tl7No-1AG-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote: > Description: No need for that line. > in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'. Why indent? Also, you need to be specific as to what type of changes you made. > Also, fixing logical issue, i.e. removing break after goto statement. Don't do multiple things in the same patch, break it up into one-patch-per-thing, and no, "checkpatch.pl cleanups" is not "one thing" :) thanks, greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] vc04_services: Fixing coding and logical guidelines Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-15 04:30 +0100
Re: [PATCH] vc04_services: Fixing coding and logical guidelines Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-15 06:00 +0100
Re: [PATCH] vc04_services: Fixing coding and logical guidelines Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-03-15 06:10 +0100
csiph-web