Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing

From	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing
Date	2017-03-14 21:30 +0100
Message-ID	<tl1eW-5s2-31@gated-at.bofh.it> (permalink)
References	<tkZZw-4D5-17@gated-at.bofh.it> <tl0sy-4RE-3@gated-at.bofh.it>
Organization	Free Electrons

Show all headers | View raw

Hello,

On Tue, 14 Mar 2017 14:30:05 -0500, Bjorn Helgaas wrote:
> On Tue, Mar 14, 2017 at 12:08:51PM -0700, Stephen Boyd wrote:
> > This code assigns variables that are never used. Remove them.
> > 
> > Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>  
> 
> I love removing unused code!  Applied to pci/host-aardvark for v4.12,
> thanks!

Why? I have already sent a patch that also does this (and much more!) a
number of times already, and it has never been applied. See:

  [PATCH v3 1/3] pci: pci-aardvark: move to MSI handling using generic MSI support

v1 on September 1st, 2016
v2 on December 23th, 2016
v3 on February 28th, 2017

Best regards,

Thomas

-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] PCI: aardvark: Remove msi-controller dt node probing Stephen Boyd <stephen.boyd@linaro.org> - 2017-03-14 20:10 +0100
  Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing Bjorn Helgaas <helgaas@kernel.org> - 2017-03-14 20:40 +0100
    Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing Bjorn Helgaas <helgaas@kernel.org> - 2017-03-14 21:20 +0100
    Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-03-14 21:30 +0100

csiph-web