Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1600850

Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing

Show all headers | View raw

On Tue, Mar 14, 2017 at 12:08:51PM -0700, Stephen Boyd wrote:
> This code assigns variables that are never used. Remove them.
> 
> Reported-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>

I love removing unused code!  Applied to pci/host-aardvark for v4.12,
thanks!

> ---
>  drivers/pci/host/pci-aardvark.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/pci/host/pci-aardvark.c b/drivers/pci/host/pci-aardvark.c
> index 4fce494271cc..56e1aead65fc 100644
> --- a/drivers/pci/host/pci-aardvark.c
> +++ b/drivers/pci/host/pci-aardvark.c
> @@ -917,8 +917,6 @@ static int advk_pcie_probe(struct platform_device *pdev)
>  	struct advk_pcie *pcie;
>  	struct resource *res;
>  	struct pci_bus *bus, *child;
> -	struct msi_controller *msi;
> -	struct device_node *msi_node;
>  	int ret, irq;
>  
>  	pcie = devm_kzalloc(dev, sizeof(struct advk_pcie), GFP_KERNEL);
> @@ -962,12 +960,6 @@ static int advk_pcie_probe(struct platform_device *pdev)
>  		return ret;
>  	}
>  
> -	msi_node = of_parse_phandle(dev->of_node, "msi-parent", 0);
> -	if (msi_node)
> -		msi = of_pci_find_msi_chip_by_node(msi_node);
> -	else
> -		msi = NULL;
> -
>  	bus = pci_scan_root_bus_msi(dev, 0, &advk_pcie_ops,
>  				    pcie, &pcie->resources, &pcie->msi);
>  	if (!bus) {
> -- 
> 2.10.0.297.gf6727b0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] PCI: aardvark: Remove msi-controller dt node probing Stephen Boyd <stephen.boyd@linaro.org> - 2017-03-14 20:10 +0100
  Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing Bjorn Helgaas <helgaas@kernel.org> - 2017-03-14 20:40 +0100
    Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing Bjorn Helgaas <helgaas@kernel.org> - 2017-03-14 21:20 +0100
    Re: [PATCH] PCI: aardvark: Remove msi-controller dt node probing Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-03-14 21:30 +0100

csiph-web