Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1598864

Re: [PATCH v3 1/2] net: sched: make default fifo qdiscs appear in the dump

Show all headers | View raw

From: Jiri Kosina <jikos@kernel.org>
Date: Wed, 8 Mar 2017 16:03:32 +0100 (CET)

> From: Jiri Kosina <jkosina@suse.cz>
> 
> The original reason [1] for having hidden qdiscs (potential scalability
> issues in qdisc_match_from_root() with single linked list in case of large
> amount of qdiscs) has been invalidated by 59cc1f61f0 ("net: sched: convert
> qdisc linked list to hashtable").
> 
> This allows us for bringing more clarity and determinism into the dump by
> making default pfifo qdiscs visible.
> 
> We're not turning this on by default though, at it was deemed [2] too
> intrusive / unnecessary change of default behavior towards userspace.
> Instead, TCA_DUMP_INVISIBLE netlink attribute is introduced, which allows
> applications to request complete qdisc hierarchy dump, including the
> ones that have always been implicit/invisible.
> 
> Singleton noop_qdisc stays invisible, as teaching the whole infrastructure
> about singletons would require quite some surgery with very little gain
> (seeing no qdisc or seeing noop qdisc in the dump is probably setting
> the same user expectation).
> 
> [1] http://lkml.kernel.org/r/1460732328.10638.74.camel@edumazet-glaptop3.roam.corp.google.com
> [2] http://lkml.kernel.org/r/20161021.105935.1907696543877061916.davem@davemloft.net
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Applied, thanks Jiri.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the  dump Jiri Kosina <jikos@kernel.org> - 2017-03-08 13:30 +0100
  Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in  the dump Jiri Pirko <jiri@resnulli.us> - 2017-03-08 16:00 +0100
  Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in  the dump Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-08 16:20 +0100
    Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in  the dump Jiri Kosina <jikos@kernel.org> - 2017-03-08 16:40 +0100
  [PATCH v3 1/2] net: sched: make default fifo qdiscs appear in the  dump Jiri Kosina <jikos@kernel.org> - 2017-03-08 16:30 +0100
    Re: [PATCH v3 1/2] net: sched: make default fifo qdiscs appear in  the dump David Miller <davem@davemloft.net> - 2017-03-13 07:00 +0100

csiph-web