Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1595294

Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

Show all headers | View raw

On Wed, 8 Mar 2017, Eric Dumazet wrote:

> > +++ b/net/sched/sch_qfq.c
> > @@ -494,6 +494,8 @@ static int qfq_change_class(struct Qdisc *sch, u32 classid, u32 parentid,
> >  			goto destroy_class;
> >  	}
> >  
> > +	if (cl->qdisc != &noop_qdisc)
> > +		qdisc_hash_add(cl->qdisc, true);
> 
> 
> Please move the test in qdisc_hash_add() instead of copy/pasting it all
> over the places ?

Well, qdisc_hash_add() has a WARN_ON() (inherited from what 
qdisc_list_add() used to do) for that particular case to catch cases where 
singleton qdisc would make it there from other places by mistake. By 
putting this test there we'll effectively giving up on this warning should 
it ever point to a bug.

Thanks,

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the  dump Jiri Kosina <jikos@kernel.org> - 2017-03-08 13:30 +0100
  Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in  the dump Jiri Pirko <jiri@resnulli.us> - 2017-03-08 16:00 +0100
  Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in  the dump Eric Dumazet <eric.dumazet@gmail.com> - 2017-03-08 16:20 +0100
    Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in  the dump Jiri Kosina <jikos@kernel.org> - 2017-03-08 16:40 +0100
  [PATCH v3 1/2] net: sched: make default fifo qdiscs appear in the  dump Jiri Kosina <jikos@kernel.org> - 2017-03-08 16:30 +0100
    Re: [PATCH v3 1/2] net: sched: make default fifo qdiscs appear in  the dump David Miller <davem@davemloft.net> - 2017-03-13 07:00 +0100

csiph-web