Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1598849
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/7] regulator: max1586: Constify regulator_ops |
| Date | 2017-03-13 06:20 +0100 |
| Message-ID | <tkqyJ-3Xf-3@gated-at.bofh.it> (permalink) |
| References | <tkqyJ-3Xf-5@gated-at.bofh.it> <tjUyR-78s-7@gated-at.bofh.it> |
| Organization | Samsung Electronics |
Dear all,
All patches in this series looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Best Regards,
Chanwoo Choi
On 2017년 03월 12일 04:01, Krzysztof Kozlowski wrote:
> Static struct regulator_ops is not modified so can be made const for
> code safeness.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/regulator/max1586.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/max1586.c b/drivers/regulator/max1586.c
> index 2c1228d5796a..6779c2b53674 100644
> --- a/drivers/regulator/max1586.c
> +++ b/drivers/regulator/max1586.c
> @@ -126,14 +126,14 @@ static int max1586_v6_set_voltage_sel(struct regulator_dev *rdev,
> * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back
> * the set up value.
> */
> -static struct regulator_ops max1586_v3_ops = {
> +static const struct regulator_ops max1586_v3_ops = {
> .get_voltage_sel = max1586_v3_get_voltage_sel,
> .set_voltage_sel = max1586_v3_set_voltage_sel,
> .list_voltage = regulator_list_voltage_linear,
> .map_voltage = regulator_map_voltage_linear,
> };
>
> -static struct regulator_ops max1586_v6_ops = {
> +static const struct regulator_ops max1586_v6_ops = {
> .get_voltage_sel = max1586_v6_get_voltage_sel,
> .set_voltage_sel = max1586_v6_set_voltage_sel,
> .list_voltage = regulator_list_voltage_table,
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/7] regulator: max1586: Constify regulator_ops Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
[PATCH 4/7] regulator: s2mpa01: Constify regulator_ops Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
Applied "regulator: s2mpa01: Constify regulator_ops" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
[PATCH 3/7] regulator: max8660: Constify regulator_ops Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
Applied "regulator: max8660: Constify regulator_ops" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
[PATCH 7/7] regulator: s2mpa01: Fix inconsistent indenting Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
Applied "regulator: s2mpa01: Fix inconsistent indenting" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
[PATCH 5/7] regulator: s2mps11: Constify regulator_ops Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
Applied "regulator: s2mps11: Constify regulator_ops" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
[PATCH 2/7] regulator: max77693: Constify regulator_ops Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
Re: [PATCH 2/7] regulator: max77693: Constify regulator_ops Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-13 06:00 +0100
Applied "regulator: max77693: Constify regulator_ops" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
Re: [PATCH 1/7] regulator: max1586: Constify regulator_ops Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-13 06:20 +0100
Applied "regulator: max1586: Constify regulator_ops" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
csiph-web