Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1598846
| From | Chanwoo Choi <cw00.choi@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/7] regulator: max77693: Constify regulator_ops |
| Date | 2017-03-13 06:00 +0100 |
| Message-ID | <tkqfn-3wV-1@gated-at.bofh.it> (permalink) |
| References | <tjUyR-78s-7@gated-at.bofh.it> <tkqfn-3wV-3@gated-at.bofh.it> <tjUyS-78s-41@gated-at.bofh.it> |
| Organization | Samsung Electronics |
Hi,
On 2017년 03월 12일 04:01, Krzysztof Kozlowski wrote:
> Static struct regulator_ops is not modified so can be made const for
> code safeness.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/regulator/max77693-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/max77693-regulator.c b/drivers/regulator/max77693-regulator.c
> index 3fce67982682..e7000e777292 100644
> --- a/drivers/regulator/max77693-regulator.c
> +++ b/drivers/regulator/max77693-regulator.c
> @@ -150,7 +150,7 @@ static const struct regulator_ops max77693_safeout_ops = {
> .set_voltage_sel = regulator_set_voltage_sel_regmap,
> };
>
> -static struct regulator_ops max77693_charger_ops = {
> +static const struct regulator_ops max77693_charger_ops = {
> .is_enabled = regulator_is_enabled_regmap,
> .enable = regulator_enable_regmap,
> .disable = regulator_disable_regmap,
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/7] regulator: max1586: Constify regulator_ops Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
[PATCH 4/7] regulator: s2mpa01: Constify regulator_ops Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
Applied "regulator: s2mpa01: Constify regulator_ops" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
[PATCH 3/7] regulator: max8660: Constify regulator_ops Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
Applied "regulator: max8660: Constify regulator_ops" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
[PATCH 7/7] regulator: s2mpa01: Fix inconsistent indenting Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
Applied "regulator: s2mpa01: Fix inconsistent indenting" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
[PATCH 5/7] regulator: s2mps11: Constify regulator_ops Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
Applied "regulator: s2mps11: Constify regulator_ops" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
[PATCH 2/7] regulator: max77693: Constify regulator_ops Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 20:10 +0100
Re: [PATCH 2/7] regulator: max77693: Constify regulator_ops Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-13 06:00 +0100
Applied "regulator: max77693: Constify regulator_ops" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
Re: [PATCH 1/7] regulator: max1586: Constify regulator_ops Chanwoo Choi <cw00.choi@samsung.com> - 2017-03-13 06:20 +0100
Applied "regulator: max1586: Constify regulator_ops" to the regulator tree Mark Brown <broonie@kernel.org> - 2017-03-13 18:00 +0100
csiph-web