Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()

From	SIMRAN SINGHAL <singhalsimran0@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()
Date	2017-03-12 16:50 +0100
Message-ID	<tkdUR-3xx-3@gated-at.bofh.it> (permalink)
References	<tjsW0-4FY-75@gated-at.bofh.it> <tkccq-2gk-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Mar 12, 2017 at 7:24 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote:
>> The function atomisp_set_stop_timeout on being called, simply returns
>> back. The function hasn't been mentioned in the TODO and doesn't have
>> FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
>> removed.
>>
>> This was done using Coccinelle.
>>
>> @@
>> identifier f;
>> @@
>>
>> void f(...) {
>>
>> -return;
>>
>> }
>>
>> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
>> ---
>>  v1:
>>    -Change Subject to include name of function
>>    -change commit message to include the coccinelle script
>
> You should also cc: the developers doing all of the current work on this
> driver, Alan Cox, to get their comment if this really is something that
> can be removed or not.
>
> thanks,
>
Greg I have cc'd all the developers which script get_maintainer.pl showed:

$ git show HEAD | perl scripts/get_maintainer.pl --separator ,
--nokeywords --nogit --nogit-fallback --norolestats

Mauro Carvalho Chehab <mchehab@kernel.org>,Greg Kroah-Hartman
<gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org

> greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1] staging: media: Remove unused function  atomisp_set_stop_timeout() simran singhal <singhalsimran0@gmail.com> - 2017-03-10 14:40 +0100
  Re: [PATCH v1] staging: media: Remove unused function  atomisp_set_stop_timeout() Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 15:00 +0100
    Re: [Outreachy kernel] Re: [PATCH v1] staging: media: Remove unused  function atomisp_set_stop_timeout() Julia Lawall <julia.lawall@lip6.fr> - 2017-03-12 16:50 +0100
    Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout() SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-12 16:50 +0100

csiph-web