Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1598628

Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()

Show all headers | View raw

On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote:
> The function atomisp_set_stop_timeout on being called, simply returns
> back. The function hasn't been mentioned in the TODO and doesn't have
> FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
> removed.
> 
> This was done using Coccinelle.
> 
> @@
> identifier f;
> @@
> 
> void f(...) {
> 
> -return;
> 
> }
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  v1:
>    -Change Subject to include name of function
>    -change commit message to include the coccinelle script

You should also cc: the developers doing all of the current work on this
driver, Alan Cox, to get their comment if this really is something that
can be removed or not.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v1] staging: media: Remove unused function  atomisp_set_stop_timeout() simran singhal <singhalsimran0@gmail.com> - 2017-03-10 14:40 +0100
  Re: [PATCH v1] staging: media: Remove unused function  atomisp_set_stop_timeout() Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 15:00 +0100
    Re: [Outreachy kernel] Re: [PATCH v1] staging: media: Remove unused  function atomisp_set_stop_timeout() Julia Lawall <julia.lawall@lip6.fr> - 2017-03-12 16:50 +0100
    Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout() SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-03-12 16:50 +0100

csiph-web