Re: [PATCH] staging: speakup: Comparison to NULL could be written

Path	csiph.com!feeder.erje.net!2.eu.feeder.erje.net!feeds.phibee-telecom.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: speakup: Comparison to NULL could be written
Date	Sun, 12 Mar 2017 15:30:01 +0100
Message-ID	<tkcFr-2Iv-13@gated-at.bofh.it> (permalink)
References	<tjxVD-80K-13@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.8.0 (2017-02-23)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	w.d.hubbs@gmail.com, devel@driverdev.osuosl.org, Kirk Reiser <kirk@reisers.ca>, speakup@linux-speakup.org, linux-kernel@vger.kernel.org, Samuel Thibault <samuel.thibault@ens-lyon.org>, Chris Brannon <chris@the-brannons.com>
X-Original-Date	Sun, 12 Mar 2017 15:29:08 +0100
X-Original-Message-ID	<20170312142908.GA25500@kroah.com>
X-Original-References	<20170310185909.GA5511@arushi-HP-Pavilion-Notebook>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1598642

Show key headers only | View raw

On Sat, Mar 11, 2017 at 12:29:09AM +0530, Arushi Singhal wrote:
> Fixed coding style for null comparisons in speakup driver to be more
> consistant with the rest of the kernel coding style.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  drivers/staging/speakup/selection.c   | 2 +-
>  drivers/staging/speakup/varhandlers.c | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)

I have over 25 patches from you for this driver, and I have no idea what
ones I should be applying and in what order.  So I've had to delete them
all from my queue.  Please rebase your series on the latest
staging-testing branch and resend, as a single patch series, what you
wish to have reviewed and potentially applied.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: speakup: Comparison to NULL could be written Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-10 20:00 +0100
  Re: [PATCH] staging: speakup: Comparison to NULL could be written Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-03-12 15:30 +0100

csiph-web