Re: [PATCH] staging: fbtft: Allows bpp to be set from dt

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: fbtft: Allows bpp to be set from dt
Date	Sun, 12 Mar 2017 15:30:01 +0100
Message-ID	<tkcFr-2Iv-11@gated-at.bofh.it> (permalink)
References	<tjp25-1S9-117@gated-at.bofh.it> <tjp25-1S9-115@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.8.0 (2017-02-23)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Sun, 12 Mar 2017 15:27:34 +0100
X-Original-Message-ID	<20170312142734.GA19066@kroah.com>
X-Original-References	<1489137927-13347-1-git-send-email-radoslaw.pietrzyk@gmail.com> <1489137927-13347-2-git-send-email-radoslaw.pietrzyk@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1598641

Show key headers only | View raw

On Fri, Mar 10, 2017 at 10:25:27AM +0100, Radoslaw Pietrzyk wrote:
> Allows bpp to be set from dt
> 
> Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com>
> ---
>  drivers/staging/fbtft/fbtft-core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index 7c8af29..b25288b 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -685,6 +685,8 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
>  	/* override driver values? */
>  	if (pdata->fps)
>  		fps = pdata->fps;
> +	if (pdata->bpp)
> +		bpp = pdata->bpp;
>  	if (pdata->txbuflen)
>  		txbuflen = pdata->txbuflen;
>  	if (pdata->display.init_sequence)

This breaks the build, how did you test this???

thanks,

greg k-h

Thread

[PATCH] staging: fbtft: Allows bpp to be set from dt Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> - 2017-03-10 10:30 +0100
  Re: [PATCH] staging: fbtft: Allows bpp to be set from dt Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 15:30 +0100
  Re: [PATCH] staging: fbtft: Allows bpp to be set from dt kbuild test robot <lkp@intel.com> - 2017-03-12 23:20 +0100
  [PATCH v2] staging: fbtft: Allows bpp to be set from dt Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> - 2017-03-13 11:30 +0100
    Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-13 12:10 +0100
      Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Radosław Pietrzyk <radoslaw.pietrzyk@gmail.com> - 2017-03-13 12:10 +0100
        Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Radosław Pietrzyk <radoslaw.pietrzyk@gmail.com> - 2017-03-13 12:20 +0100
          Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-13 12:30 +0100
            Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Radosław Pietrzyk <radoslaw.pietrzyk@gmail.com> - 2017-03-13 12:30 +0100
        Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-13 12:20 +0100

csiph-web