Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1599231

Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt
Date 2017-03-13 12:30 +0100
Message-ID <tkwkN-8ew-9@gated-at.bofh.it> (permalink)
References (1 earlier) <tkvoJ-7zi-5@gated-at.bofh.it> <tkw1s-852-5@gated-at.bofh.it> <tkw1s-852-21@gated-at.bofh.it> <tkwb8-8aF-21@gated-at.bofh.it> <tkwb8-8aF-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 13, 2017 at 12:16:13PM +0100, Radosław Pietrzyk wrote:
> Ok I will. I just have thought that in general it might be helpful to
> have this possibility as DT is parsed for this option anyway. If you
> think it is not needed at all that why to bother parsing DT for this
> option in the first place ?

I'm not saying it's a wrong patch, I just think the patch description
doesn't explain why you are doing it or the user visible effects of the
change.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: fbtft: Allows bpp to be set from dt Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> - 2017-03-10 10:30 +0100
  Re: [PATCH] staging: fbtft: Allows bpp to be set from dt Greg KH <gregkh@linuxfoundation.org> - 2017-03-12 15:30 +0100
  Re: [PATCH] staging: fbtft: Allows bpp to be set from dt kbuild test robot <lkp@intel.com> - 2017-03-12 23:20 +0100
  [PATCH v2] staging: fbtft: Allows bpp to be set from dt Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com> - 2017-03-13 11:30 +0100
    Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-13 12:10 +0100
      Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Radosław Pietrzyk <radoslaw.pietrzyk@gmail.com> - 2017-03-13 12:10 +0100
        Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Radosław Pietrzyk <radoslaw.pietrzyk@gmail.com> - 2017-03-13 12:20 +0100
          Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-13 12:30 +0100
            Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Radosław Pietrzyk <radoslaw.pietrzyk@gmail.com> - 2017-03-13 12:30 +0100
        Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt Dan Carpenter <dan.carpenter@oracle.com> - 2017-03-13 12:20 +0100

csiph-web