Re: [PATCH v5 1/2] mailbox: Add driver for Broadcom FlexRM ring manager

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jassi Brar <jassisinghbrar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/2] mailbox: Add driver for Broadcom FlexRM ring manager
Date	Tue, 14 Mar 2017 18:00:02 +0100
Message-ID	<tkXXI-2UI-3@gated-at.bofh.it> (permalink)
References	<thXrb-6fC-17@gated-at.bofh.it> <thXrc-6fC-43@gated-at.bofh.it>
X-Original-To	Anup Patel <anup.patel@broadcom.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vUZWn/iptvVrK111eWZvRRiYrn6VAKymtbdukP119mY=; b=Hui4Ba7xcOH5EEqCVlo8ZhntX+Cdvu80cqjZPbPnOBRme81VMtrd9fgS0ZlJwsodDW XFh/CCNIccqzTJ/l/FgnN+B1Lv1c+P/BwhAIzY8z3aRv8QQINvsdyqWrq2E1OWz4vUhs Ugtx3HA30ND6C+VkPvpJ+wv5Rqn4bRNf6oczom3yoS6Ww1ojJ6l6K7X2ALZY5J7pGhRO ALrnSBVqqK1FFcEdhWT7E2SvX5Tr8K1cBI+a5ZC9Xi6QVBco91/HEjpVtJhaVuQQzwHg n4yPT2VZx13blmy9f2WWA+F4V8e/XSxurHvr9iqExdxa4OPtehoG4Zb38o/sZwv8ubIO aftA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vUZWn/iptvVrK111eWZvRRiYrn6VAKymtbdukP119mY=; b=oUuETrgZJn/WrE6xz88Xda6M2ZQbzuTGHw4t8b64QjGCQI/HJ4SHUrBL0iWzjuKyt5 +fri+mbgJ/7W+Gsy7gKLydezNPg8lclnEQBQMCimGMH1LxHG7ZJmKP+CaGHEMrO95pZh 5zlYEpgM3sXI+5IDy+3r0PFniV6+qLa2QBONSq28SlipwC2fGIkcgyDrbRttj/b77Q8q bxbOaQYf7b4giipdjcrR7WFAuQHiO2ORv+3WVnYWOZZliYcEm1T04Zx5o4Dz+w/416n4 cKcRagTEwTam++9vz32jff4e2SMfPxgqnd8VMnpbOeCMh6dY7XP9v9wrp9Pk0Jy6YZ7O YXMA==
X-Gm-Message-State	AMke39my6BTMZ9Wr9oqpCAb+EXHCXzWUfzCdxegVIUO1BHDtJ1G3yWe2rbKw45TuYA7QGCBQYvNNfqnu8y2GtA==
X-Received	by 10.223.131.3 with SMTP id 3mr34191116wrd.153.1489510499525; Tue, 14 Mar 2017 09:54:59 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Pramod KUMAR <pramod.kumar@broadcom.com>, Rob Rice <rob.rice@broadcom.com>, Devicetree List <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>
X-Original-Date	Tue, 14 Mar 2017 17:54:59 +0100
X-Original-Message-ID	<CABb+yY0uDhgq-8hiAAXdq35igHH1GJVuuGTmerK=9UN6_VTHnA@mail.gmail.com>
X-Original-References	<1488793240-25484-1-git-send-email-anup.patel@broadcom.com> <1488793240-25484-2-git-send-email-anup.patel@broadcom.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1600698

Show key headers only | View raw

On Mon, Mar 6, 2017 at 10:40 AM, Anup Patel <anup.patel@broadcom.com> wrote:
> Some of the Broadcom iProc SoCs have FlexRM ring manager
> which provides a ring-based programming interface to various
> offload engines (e.g. RAID, Crypto, etc).
>
> This patch adds a common mailbox driver for Broadcom FlexRM
> ring manager which can be shared by various offload engine
> drivers (implemented as mailbox clients).
>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> Reviewed-by: Pramod KUMAR <pramod.kumar@broadcom.com>
> Signed-off-by: Anup Patel <anup.patel@broadcom.com>
> ---
>  drivers/mailbox/Kconfig                      |  11 +
>  drivers/mailbox/Makefile                     |   2 +
>  drivers/mailbox/mailbox-flexrm/Makefile      |   6 +
>  drivers/mailbox/mailbox-flexrm/flexrm-desc.c | 764 ++++++++++++++++++++++++
>  drivers/mailbox/mailbox-flexrm/flexrm-desc.h |  47 ++
>  drivers/mailbox/mailbox-flexrm/flexrm-main.c | 829 +++++++++++++++++++++++++++
>  include/linux/mailbox/brcm-message.h         |  14 +-
>  7 files changed, 1669 insertions(+), 4 deletions(-)
>  create mode 100644 drivers/mailbox/mailbox-flexrm/Makefile
>  create mode 100644 drivers/mailbox/mailbox-flexrm/flexrm-desc.c
>  create mode 100644 drivers/mailbox/mailbox-flexrm/flexrm-desc.h
>  create mode 100644 drivers/mailbox/mailbox-flexrm/flexrm-main.c
>
I would avoid platform specific sub-directory if possible, because
people tend to take it as  their fenced island where they can do
whatever they like.

Can you break this into an upper BRCM specific code (desc management)
and a lower purely mailbox driver (only sets up pointers/addresses to
create rings and track the flexrm's PC)?   Is there a reason why you
must dma_map, the buffers to send, in the spinlock protected
.send_data()?

thanks

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/2] mailbox: Add driver for Broadcom FlexRM ring manager Jassi Brar <jassisinghbrar@gmail.com> - 2017-03-14 18:00 +0100
  Re: [PATCH v5 1/2] mailbox: Add driver for Broadcom FlexRM ring manager Anup Patel <anup.patel@broadcom.com> - 2017-03-15 07:40 +0100

csiph-web