Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var
Date	2017-03-14 18:00 +0100
Message-ID	<tkXXI-2UI-15@gated-at.bofh.it> (permalink)
References	<tgyOd-2Mh-19@gated-at.bofh.it> <tgyOe-2Mh-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 2017-03-02 16:11:32, Aleksey Makarov wrote:
> The variable preferred_console is used only inside register_console()
> and its semantics is boolean.  It is negative when no console has been
> made preferred.
> 
> Make it static bool and rename to has_preferred.
> 
> Renaming was suggested by Peter Hurley
> 
> Signed-off-by: Aleksey Makarov <aleksey.makarov@linaro.org>

I am sorry for the late reply. I was sick.

The change looks fine to me.

Acked-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console  var Petr Mladek <pmladek@suse.com> - 2017-03-14 18:00 +0100

csiph-web