Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var

Path	csiph.com!xmission!news.glorb.com!bofh.it!news.nic.it!robomod
From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var
Date	Tue, 14 Mar 2017 18:00:02 +0100
Message-ID	<tkXXI-2UI-15@gated-at.bofh.it> (permalink)
References	<tgyOd-2Mh-19@gated-at.bofh.it> <tgyOe-2Mh-25@gated-at.bofh.it>
X-Original-To	Aleksey Makarov <aleksey.makarov@linaro.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Peter Hurley <peter@hurleysoftware.com>, Jiri Slaby <jslaby@suse.com>, Robin Murphy <robin.murphy@arm.com>, Steven Rostedt <rostedt@goodmis.org>, "Nair, Jayachandran" <Jayachandran.Nair@cavium.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
X-Original-Date	Tue, 14 Mar 2017 17:52:44 +0100
X-Original-Message-ID	<20170314165244.GH3977@pathway.suse.cz>
X-Original-References	<20170302131153.22733-1-aleksey.makarov@linaro.org> <20170302131153.22733-2-aleksey.makarov@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1600699

Show key headers only | View raw

On Thu 2017-03-02 16:11:32, Aleksey Makarov wrote:
> The variable preferred_console is used only inside register_console()
> and its semantics is boolean.  It is negative when no console has been
> made preferred.
> 
> Make it static bool and rename to has_preferred.
> 
> Renaming was suggested by Peter Hurley
> 
> Signed-off-by: Aleksey Makarov <aleksey.makarov@linaro.org>

I am sorry for the late reply. I was sick.

The change looks fine to me.

Acked-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console  var Petr Mladek <pmladek@suse.com> - 2017-03-14 18:00 +0100

csiph-web