Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412

From	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412
Date	2017-03-14 15:10 +0100
Message-ID	<tkVjc-1eJ-23@gated-at.bofh.it> (permalink)
References	<tjT05-5YC-3@gated-at.bofh.it> <tkUn8-x2-27@gated-at.bofh.it> <tkUwO-Bf-31@gated-at.bofh.it> <tkVjc-1eJ-25@gated-at.bofh.it> <tkUwO-Bf-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday, March 14, 2017 03:09:25 PM Krzysztof Kozlowski wrote:
> On Tue, Mar 14, 2017 at 3:03 PM, Bartlomiej Zolnierkiewicz
> <b.zolnierkie@samsung.com> wrote:
> >
> > Hi,
> >
> > On Saturday, March 11, 2017 07:25:22 PM Krzysztof Kozlowski wrote:
> >> The Exynos4412 has the same watchdog as newer SoCs (e.g. Exynos5250).
> >> Just like the others, for working it requires additional steps in Power
> >> Management Unit: unmasking the reset request and enabling the system
> >> reset.  Without these additional steps in PMU, the watchdog will not be
> >> able to reset the system on expiration event.
> >>
> >> Change the compatible of Exynos4412 watchdog device node to
> >> samsung,exynos5250-wdt which includes the additional PMU steps.
> >
> > This is going to confuse people.  How's about doing it cleanly
> > (by adding samsung,exynos4412-wdt compatible and convert existing
> > users to use instead)?
> 
> I don't find usage of 5250 in Exynos4412 DTS as confusing because
> since long time I do not threat these numbers as having any meaning
> (e.g. 3250 is newer...). Yes, we can duplicate the compatible for that
> purpose. Care to send a patch for this?

I don't buy this argument. The point is not in the number itself
but in the fact that you as developer know than 3250 is newer than
4412 (the same way as you know that 5250 is also newer than 4412).
This convention is used for all Exynos bindings so please don't
break it.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-11 18:30 +0100
  Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Guenter Roeck <linux@roeck-us.net> - 2017-03-12 21:50 +0100
    Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-13 07:50 +0100
  Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 14:10 +0100
    Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Krzysztof Kozlowski <krzk@kernel.org> - 2017-03-14 14:20 +0100
      Re: [PATCH v2 3/8] ARM: dts: exynos: Fix watchdog reset on Exynos4412 Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-03-14 15:10 +0100

csiph-web